This patch adds the abstract class FormFieldSignature, implements it in poppler generator and modifies poppler generator to recognize signature
form field.
Details
- Reviewers
aacid
Diff Detail
- Repository
- R223 Okular
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage
I understand you're mimicing the poppler API at some points but that doesn't always makes sense since poppler is a multi-purpose library and okular is a document viewer.
core/form.cpp | ||
---|---|---|
292 | What's this used for? | |
core/form.h | ||
405 | What would be the usecase for this force? | |
420 | a map of strings to variants is not very good API since basically it can have any random things in there. So as a consumer of that API you're blind. Wouldn't a class/structure make sense here? | |
427 | As a viewer when would we need to have a different validation time than now? | |
generators/poppler/formfields.cpp | ||
445 | Are these strings supposed to be user visible? If so you need i18n around them | |
generators/poppler/formfields.h | ||
146 | Why do we need all these enums can't we use the ones in poppler¿ |
core/form.cpp | ||
---|---|---|
292 | For other formfields it can be used to set their default states. But for signature field I have no idea. | |
core/form.h | ||
405 | I never thought of a possible use case before duplicating it here. For now I have removed it from the patch. I will update this diff if I find any use case. | |
427 | Same here. Never actually thought of a use case and still can't find one. |
generators/poppler/pdfsignatureinfo.cpp | ||
---|---|---|
43 ↗ | (On Diff #35040) | Or use a std::unique_ptr? |
Added validateSignatures() to validate signatures while loading a page.
Added to document info whether or not a pdf is digitally signed.