Add SignatureSummaryDialog and SignaturePropertiesDialog
AbandonedPublic

Authored by chinmoyr on Jun 11 2018, 5:17 PM.

Details

Reviewers
aacid
Summary

SignatureSummaryDialog will display the signature validation summary and
SignaturePropertiesDialog will display the signature validation information.

Diff Detail

Repository
R223 Okular
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
chinmoyr created this revision.Jun 11 2018, 5:17 PM
Restricted Application added a project: Okular. · View Herald TranscriptJun 11 2018, 5:17 PM
Restricted Application added a subscriber: okular-devel. · View Herald Transcript
chinmoyr requested review of this revision.Jun 11 2018, 5:17 PM
aacid added inline comments.Tue, Jun 26, 2:13 PM
ui/signaturewidgets.cpp
158

Fixed size is usually not a good idea, why are you doing it?

168

Maybe activated makes more sense than clicked so it can be used with the keyboard too?

171

Why a readonly textedit instead of a label?

194

Same question as above

215

I'm not sure but i think it's a bit drasting closing this dialog when asking for "Signature Properties", what's the rationale behind it?

chinmoyr abandoned this revision.Tue, Jun 26, 5:19 PM

Outdated diff

ui/signaturewidgets.cpp
158

Well it's the result of taking your advice of "do what adobe does" bit too far.
Just curious, why is it bad? Because you can only see elided text? Are there other reasons?

168

For certificate viewer I will take that into consideration.

171

Because adobe reader has a read only textedit.

215

Even here I copied adobe.

aacid added inline comments.Wed, Jun 27, 10:03 PM
ui/signaturewidgets.cpp
158

So how do you know 450x400 is going to fit with my big fonts and the text in Catalan instead of English?

171

It's interesting, if you look at Firefox, it uses a label in one place and what seems to be a textedit in another, meh.

215

Yeah.... let's not copy bad UI behaviour