SignatureSummaryDialog will display the signature validation summary and
SignaturePropertiesDialog will display the signature validation information.
Details
Details
- Reviewers
aacid
Diff Detail
Diff Detail
- Repository
- R223 Okular
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage
ui/signaturewidgets.cpp | ||
---|---|---|
158 | Fixed size is usually not a good idea, why are you doing it? | |
168 | Maybe activated makes more sense than clicked so it can be used with the keyboard too? | |
171 | Why a readonly textedit instead of a label? | |
194 | Same question as above | |
215 | I'm not sure but i think it's a bit drasting closing this dialog when asking for "Signature Properties", what's the rationale behind it? |
Comment Actions
Outdated diff
ui/signaturewidgets.cpp | ||
---|---|---|
158 | Well it's the result of taking your advice of "do what adobe does" bit too far. | |
168 | For certificate viewer I will take that into consideration. | |
171 | Because adobe reader has a read only textedit. | |
215 | Even here I copied adobe. |