Fixed the issue with jump back actions not closing bookmark menu when triggered
ClosedPublic
Actions

Authored by nmel on Mar 26 2018, 6:59 AM.

Details

Reviewers

martinkostolny
rade

Group Reviewers

Krusader

Commits

Summary

As discussed in D11624, I'm fixing the issue with not closing bookmark menu.

Test Plan

Test jump back actions in bookmark menu triggered by mouse, keyboard, search.

Repository

R167 Krusader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

nmel requested review of this revision.Mar 26 2018, 6:59 AM

nmel created this revision.

Works nice, thanks!

Please see my code comment.

krusader/BookMan/krbookmarkhandler.cpp
488	There is a possibility to use a UniqueConnection instead of disconnect & connect. But we would need to create a standard method for closing the popup (named e.g. `KrBookmarkHandler::slotCloseBookmarkPopup`) instead of `slotTriggered` lambda. Maybe it could also be then re-used in `KrBookmarkHandler::slotActivated`. Then we could just call here this: connect(action, &QAction::triggered, this, &KrBookmarkHandler::slotCloseBookmarkPopup, Qt::UniqueConnection); But it's just a suggestion.

This revision is now accepted and ready to land.Mar 26 2018, 9:20 PM

Thanks for review and testing!

krusader/BookMan/krbookmarkhandler.cpp
488	It's a great suggestion. I think I'll do this as a part of CONNECT_BM refactoring later.

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			krusader/BookMan/krbookmarkhandler.cpp (31 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	30593	2bbaedf		Mar 26 2018, 6:59 AM	★	★
Diff 2	30687	2bbaedf	R167:61a46a181598002c9f18ad4ceb8d4f0492edf31d	Mar 27 2018, 5:49 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
e7900ff15b1f	4fa9a3eac900	2bbaedfebaf7	Nikita Melnichenko	Fixed the issue with jump back actions not closing bookmark menu when triggered	Mar 26 2018, 6:52 AM