no longer have a play icon bouncing but use an icon like the plasma taskbar
We no longer have an animation running when music is playing. We should no longer have excess cpu usage.
We now use a common icon to indicate the playing track (plasma task bar, firefox tabs, ...)
cpu usage should be lower when playing music
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
Looks good and I'm in favor of this due to consistency, but I haven't seen a drop in cpu usage. Elisa is always somewhere between 2 to 4 %. Is that too much for a music player?
A small addition would be to alter the appearance of the icon when the track is paused, maybe some opacity or hiding it completely (the latter is what the task bar is doing)
the BusyIndicator sometime was generating constant refresh of the display generating a lot of cpu usage
There are status icons: media-playback-playing, media-playback-paused and media-playback-stopped in breeze-icons since recently.
Thanks, I will definitely consider them. I had forgotten about them even if they probably are the right one to use here. This also improves consistency with the mpris2 plasma applet.
We may not be able to depend on future 5.45 release of frameworks for the coming 0.1 release of Elisa. This is probably a candidate for master only branch once v5.45 is released.