Differential D11566

KCapacityBar: set QStyle::State_Horizontal state
ClosedPublic
Actions

Authored by zzag on Mar 22 2018, 1:38 AM.

Details

Reviewers
cfeck
elvisangelaccio
Commits
R236:e489bebd3df0: KCapacityBar: set QStyle::State_Horizontal state
Summary

QStyleOptionProgressBarV2 has been deprecated in favor of QStyleOptionProgressBar.
Beside that, ::orientation member has also been deprecated in favor of
checking the QStyle::State_Horizontal flag.

We need to set the QStyle::State_Horizontal state so widget styles which
don't use QStyleOptionProgressBarV2 can properly style KCapacityBar.

See http://doc-snapshots.qt.io/qt5-5.11/qstyleoptionprogressbar-obsolete.html

Diff Detail

Repository
R236 KWidgetsAddons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Mar 22 2018, 1:38 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 22 2018, 1:38 AM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
zzag requested review of this revision.Mar 22 2018, 1:38 AM
zzag added a comment.EditedMar 22 2018, 1:43 AM

otherwise, StatusBarSpaceInfo(in Dolphin) would be rendered with Breeze as following

(it assumes this is a vertical progress bar)

cfeck accepted this revision.Mar 22 2018, 3:00 AM
This revision is now accepted and ready to land.Mar 22 2018, 3:00 AM
Closed by commit R236:e489bebd3df0: KCapacityBar: set QStyle::State_Horizontal state (authored by zzag). · Explain WhyMar 22 2018, 2:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/kcapacitybar.cpp (1 line)

Diff 30228

View Options

src/kcapacitybar.cpp

Loading...