It's not that complicated, you can try to understand it: Look at src/CMakeLists.txt, where a bunch of files is listed for compilation. However, note that all lines which are to be removed start with #, i.e. they were commented out before and thus nothing will actually change in the final build.

Next, check that what is being removed from this file is also reflected in deletions of the affected files. The src/naturalqueryparser directory seems to be removed completely, which is fine. However, see inline comment for the rest.

Too bad this has to go. At least let me add a link here to the project with some screenshots, because the idea was really nice after all: http://steckdenis.be/post-2013-09-25-the-end-of-the-google-summer-of-code.html

(And this idea has some relevance to the recent discussions about handling variable picking in Dolphin/Spectacle/Gwenview, not to mention Mycroft…)

src/CMakeLists.txt
19–21	@lueck Should those files (as well as the corresponding header files) also be removed?

delete more files commented from build as pointed out by Henrik

baloo-widgets/test/querybuilderapp.cpp can also be removed and
baloo-widgets/test/CMakeLists.txt can be changed.

This revision now requires changes to proceed.Mar 30 2018, 11:40 AM

delete more obsolete naturalqueryparser files in subdir test as pointed out by Michael, thanks

Frühjahrsputz accepted :)

This revision is now accepted and ready to land.Mar 30 2018, 12:03 PM

Closed by commit R824:bf4faa2f830d: Remove dead code (src/naturalqueryparser/) in baloo-widgets (authored by lueck). · Explain WhyMar 30 2018, 12:58 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		src/CMakeLists.txt (7 lines)
D	M	src/groupedlineedit.h (130 lines)
D	M	src/groupedlineedit.cpp (207 lines)
D	M	src/naturalqueryparser/CMakeLists.txt (68 lines)
D	M	src/naturalqueryparser/Messages.sh (2 lines)
D	M	src/naturalqueryparser/autotests/CMakeLists.txt (9 lines)
D	M	src/naturalqueryparser/autotests/naturalqueryparsertest.h (46 lines)
D	M	src/naturalqueryparser/autotests/naturalqueryparsertest.cpp (159 lines)
D	M	src/naturalqueryparser/completionproposal.h (124 lines)
D	M	src/naturalqueryparser/completionproposal.cpp (85 lines)
D	M	src/naturalqueryparser/naturalfilequeryparser.h (72 lines)
D	M	src/naturalqueryparser/naturalfilequeryparser.cpp (93 lines)
D	M	src/naturalqueryparser/naturalqueryparser.h (185 lines)
D	M	src/naturalqueryparser/naturalqueryparser.cpp (788 lines)
D	M	src/naturalqueryparser/naturalqueryparser_p.h (32 lines)
D	M	src/naturalqueryparser/pass_comparators.h (40 lines)
D	M	src/naturalqueryparser/pass_comparators.cpp (41 lines)
D	M	src/naturalqueryparser/pass_dateperiods.h (74 lines)
D	M	src/naturalqueryparser/pass_dateperiods.cpp (127 lines)
D	M	src/naturalqueryparser/pass_datevalues.h (40 lines)
D	M	src/naturalqueryparser/pass_datevalues.cpp (112 lines)
D	M	src/naturalqueryparser/pass_decimalvalues.h (33 lines)
D	M	src/naturalqueryparser/pass_decimalvalues.cpp (64 lines)
D	M	src/naturalqueryparser/pass_filenames.h (33 lines)
D	M	src/naturalqueryparser/pass_filenames.cpp (58 lines)
D	M	src/naturalqueryparser/pass_filesize.h (43 lines)
D	M	src/naturalqueryparser/pass_filesize.cpp (78 lines)
D	M	src/naturalqueryparser/pass_numbers.h (42 lines)
D	M	src/naturalqueryparser/pass_numbers.cpp (78 lines)
D	M	src/naturalqueryparser/pass_periodnames.h (43 lines)
D	M	src/naturalqueryparser/pass_periodnames.cpp (101 lines)
D	M	src/naturalqueryparser/pass_properties.h (54 lines)
D	M	src/naturalqueryparser/pass_properties.cpp (94 lines)
D	M	src/naturalqueryparser/pass_propertyinfo.h (38 lines)
D	M	src/naturalqueryparser/pass_propertyinfo.cpp (53 lines)
D	M	src/naturalqueryparser/pass_splitunits.h (40 lines)
D	M	src/naturalqueryparser/pass_splitunits.cpp (98 lines)
D	M	src/naturalqueryparser/pass_subqueries.h (39 lines)
D	M	src/naturalqueryparser/pass_subqueries.cpp (40 lines)
D	M	src/naturalqueryparser/pass_typehints.h (44 lines)
D	M	src/naturalqueryparser/pass_typehints.cpp (76 lines)
D	M	src/naturalqueryparser/patternmatcher.h (113 lines)
D	M	src/naturalqueryparser/patternmatcher.cpp (226 lines)
D	M	src/naturalqueryparser/utils.h (42 lines)
D	M	src/naturalqueryparser/utils.cpp (171 lines)
D	M	src/querybuilder.h (70 lines)
D	M	src/querybuilder.cpp (182 lines)
D	M	src/querybuildercompleter.cpp (277 lines)
D	M	src/querybuildercompleter_p.h (65 lines)
M		test/CMakeLists.txt (8 lines)
D	M	test/querybuilderapp.cpp (35 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	30051			Mar 20 2018, 9:11 PM	★	★
Diff 2	30186			Mar 22 2018, 6:05 AM	★	★
Diff 3	30918			Mar 30 2018, 11:59 AM	★	★
Diff 4	30931	507cb3f	R824:bf4faa2f830d290a6a0f4bac471baec54aeeeba5	Mar 30 2018, 12:57 PM	★	★

Remove dead code (src/naturalqueryparser/) in baloo-wdgetsClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 30931

src/CMakeLists.txt

src/groupedlineedit.h

src/groupedlineedit.cpp

src/naturalqueryparser/CMakeLists.txt

src/naturalqueryparser/Messages.sh

src/naturalqueryparser/autotests/CMakeLists.txt

src/naturalqueryparser/autotests/naturalqueryparsertest.h

src/naturalqueryparser/autotests/naturalqueryparsertest.cpp

src/naturalqueryparser/completionproposal.h

src/naturalqueryparser/completionproposal.cpp

src/naturalqueryparser/naturalfilequeryparser.h

src/naturalqueryparser/naturalfilequeryparser.cpp

src/naturalqueryparser/naturalqueryparser.h

src/naturalqueryparser/naturalqueryparser.cpp

src/naturalqueryparser/naturalqueryparser_p.h

src/naturalqueryparser/pass_comparators.h

src/naturalqueryparser/pass_comparators.cpp

src/naturalqueryparser/pass_dateperiods.h

src/naturalqueryparser/pass_dateperiods.cpp

src/naturalqueryparser/pass_datevalues.h

src/naturalqueryparser/pass_datevalues.cpp

src/naturalqueryparser/pass_decimalvalues.h

src/naturalqueryparser/pass_decimalvalues.cpp

src/naturalqueryparser/pass_filenames.h

src/naturalqueryparser/pass_filenames.cpp

src/naturalqueryparser/pass_filesize.h

src/naturalqueryparser/pass_filesize.cpp

src/naturalqueryparser/pass_numbers.h

src/naturalqueryparser/pass_numbers.cpp

src/naturalqueryparser/pass_periodnames.h

src/naturalqueryparser/pass_periodnames.cpp

src/naturalqueryparser/pass_properties.h

src/naturalqueryparser/pass_properties.cpp

src/naturalqueryparser/pass_propertyinfo.h

src/naturalqueryparser/pass_propertyinfo.cpp

src/naturalqueryparser/pass_splitunits.h

src/naturalqueryparser/pass_splitunits.cpp

src/naturalqueryparser/pass_subqueries.h

src/naturalqueryparser/pass_subqueries.cpp

src/naturalqueryparser/pass_typehints.h

src/naturalqueryparser/pass_typehints.cpp

src/naturalqueryparser/patternmatcher.h

src/naturalqueryparser/patternmatcher.cpp

src/naturalqueryparser/utils.h

src/naturalqueryparser/utils.cpp

src/querybuilder.h

src/querybuilder.cpp

src/querybuildercompleter.cpp

src/querybuildercompleter_p.h

test/CMakeLists.txt

test/querybuilderapp.cpp

Remove dead code (src/naturalqueryparser/) in baloo-wdgets
ClosedPublic
Actions

Revision Contents
Changeset List