Differential D11510

[KPropertiesDialog] Support Checksum tab for any local path
ClosedPublic
Actions

Authored by broulik on Mar 20 2018, 3:06 PM.

Details

Reviewers
dfaure
elvisangelaccio
hein
Group Reviewers
Frameworks
Commits
R241:7d6e4965dfcd: [KPropertiesDialog] Support Checksum tab for any local path
Summary

computeChecksum was already called with localPath() so check for it not being empty rather than isLocalFile().
This allows to calculate checksums also from e.g. desktop:/

BUG: 392100

Test Plan

Verified that "Checksum" tab shows up for files on the desktop and verified that checksums for desktop:/foo.txt are the same as file:///home/foo/Desktop/foo.txt

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Mar 20 2018, 3:06 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 20 2018, 3:06 PM
broulik requested review of this revision.Mar 20 2018, 3:06 PM
hein accepted this revision.Mar 20 2018, 6:57 PM
This revision is now accepted and ready to land.Mar 20 2018, 6:57 PM
Closed by commit R241:7d6e4965dfcd: [KPropertiesDialog] Support Checksum tab for any local path (authored by broulik). · Explain WhyMar 21 2018, 8:50 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/widgets/kpropertiesdialog.cpp (2 lines)

Diff 30100

View Options

src/widgets/kpropertiesdialog.cpp

Loading...