| dhaumann | |
| cullmann |
| Framework: Syntax Highlighting |
Previously, the variables prefixed by if / case / loop / end are a mix of keywords and normal text.
Improvements:
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
There is a bug on which I fell while completing the tests: the output is not stable.
Several successive calls to ./bin/kate-syntax-highlighter $PROJ/autotests/input/test.sql give a different result. valgrind returns a lot of "Conditional jump or move depends on uninitialised value(s) ", but I do not have the debug symbols and I do not know which library the error comes from (I tried with qt5-debug-base without result).
Looks mostly good, but there are some minor issues we first need to address:
Please provide an updated revision, I think the next one is good to go in. :-)
| data/syntax/sql-mysql.xml | ||
|---|---|---|
| 9 | kateversion="5.0" is required due to dsControlFlow. | |
| data/syntax/sql-oracle.xml | ||
| 4 | Since you are using dsControlFlow and similar new itemDatas, you have to change kateversion="5.0". | |
| 1876 | Hm, I can see that WordDetect is possibly faster than the RegExpr here. Still, I *assume* there are arbitrary many spaces allowed in "end if". If (and only if) this is true, then I would prefer to keep the RegExpr variant. Same for the others. The changes from StringDetect to WordDetect are certainly fine. | |
| data/syntax/sql-postgresql.xml | ||
| 6 | kateversion="5.0" :-) | |
| data/syntax/sql.xml | ||
| 8 | kateversion="5.0" | |
I am completely lost with arc diff. The command adds files that I did not normally modify in this branch and specifiying a reference commit does not seem to work.
I ended up doing everything through a new branch, sorry to rot the history like this :/.
Sorry for chiming in, but in light of the focus goal T7116: Streamlined onboarding of new contributors it's important to fix rough edges in our infrastructure, too:
Do you know about our recommended workflow in https://community.kde.org/Infrastructure/Phabricator#Workflow? Happy to help with that, just let me know.
I ended up doing everything through a new branch, sorry to rot the history like this :/.
Phabricator's Differential is simply a list of patch iterations if you will, there is no "history" as such which you might have impacted. Only if you use the web uploader instead of Arcanist you make life for the reviewer a bit harder (no author information when landing, no context in the diff view, no base commit).
The page on Phabricator is much better than before. My problem was about creating a branch without the -t option which requires me to specify a commit/branch to do the diff.
I also realized later that I was reloading a page from the revision history, so I always saw the same bad file list and did not understand why. In fact, the last 3 diff are exactly the same.
There have been changes in the xml files that will cause conflicts. I would look in the next few days.