Differential D11321

[FileItemActionPlugin] Use kdeconnect icon for submenu with multiple devices
ClosedPublic
Actions

Authored by broulik on Mar 14 2018, 10:37 AM.

Details

Reviewers
apol
Commits
R224:01159b1add0b: [FileItemActionPlugin] Use kdeconnect icon for submenu with multiple devices
Summary

It's more recognizable than the generic globe icon

Diff Detail

Repository
R224 KDE Connect
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik requested review of this revision.Mar 14 2018, 10:37 AM
broulik created this revision.
broulik retitled this revision from [FileItemActionPlugin] Use kdeconnect icon in for submenu with multiple devies to [FileItemActionPlugin] Use kdeconnect icon for submenu with multiple devices.Mar 14 2018, 12:35 PM
broulik edited the summary of this revision. (Show Details)
apol accepted this revision.Mar 14 2018, 2:15 PM
This revision is now accepted and ready to land.Mar 14 2018, 2:15 PM
Closed by commit R224:01159b1add0b: [FileItemActionPlugin] Use kdeconnect icon for submenu with multiple devices (authored by broulik). · Explain WhyMar 14 2018, 2:16 PM
This revision was automatically updated to reflect the committed changes.
nicolasfella added a subscriber: nicolasfella.Mar 14 2018, 5:37 PM

@broulik In the future it would be nice if you add KDE Connect as reviewers/subscribers, not only Aleix, to give the other members of KDE Connect the chance to give input

Revision Contents
Changeset List

Diff 29503

View Options

fileitemactionplugin/sendfileitemaction.cpp

Loading...