Differential D11309

Use the default Plasma wallpaper on the login screen
ClosedPublic
Actions

Authored by davidedmundson on Mar 14 2018, 4:27 AM.

Details

Reviewers
broulik
abetts
ngraham
mart
Group Reviewers
Plasma
VDG
Commits
R120:05b096135ca9: Use the default Plasma wallpaper on the login screen
Summary

As discussed and agreed to by VDG (T7914), change the SDDM theme background from the blue color to the current Plasma wallpaper.

BUG: 381407
FIXED-IN: 5.13.0

Test Plan
  • Build and deploy plasma-workspace with this patch
  • Log out

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Mar 14 2018, 4:27 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 14 2018, 4:27 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Mar 14 2018, 4:27 AM
ngraham edited the summary of this revision. (Show Details)Mar 14 2018, 4:30 AM
ngraham edited the test plan for this revision. (Show Details)
broulik requested changes to this revision.Mar 14 2018, 7:33 AM
broulik added a subscriber: broulik.
broulik added inline comments.
sddm-theme/theme.conf
1

This must follow ${KDE_INSTALL_DATADIR} or whatever this cmake variable this is (I'm not good at build systems)

This revision now requires changes to proceed.Mar 14 2018, 7:33 AM
abetts accepted this revision.Mar 14 2018, 2:37 PM
davidedmundson commandeered this revision.Mar 14 2018, 3:37 PM
davidedmundson added a reviewer: ngraham.
davidedmundson added a subscriber: davidedmundson.
davidedmundson updated this revision to Diff 29507.Mar 14 2018, 3:38 PM

The same but different

ngraham added a comment.Mar 14 2018, 6:28 PM
This comment was removed by ngraham.
ngraham accepted this revision.Mar 14 2018, 6:46 PM

Thanks for grabbing this, David!

mart added a subscriber: mart.Mar 15 2018, 10:15 AM

if vdg agrees ok... i'm still not sure about this

davidedmundson added a comment.Mar 15 2018, 11:59 AM

if vdg agrees ok... i'm still not sure about this

Will wait for the relevant screenlocker thread

mart accepted this revision.Apr 22 2018, 2:24 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 22 2018, 2:45 PM
Closed by commit R120:05b096135ca9: Use the default Plasma wallpaper on the login screen (authored by davidedmundson). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (7 lines)
DMsddm-theme/theme.conf (4 lines)
AMsddm-theme/theme.conf.cmake (4 lines)

Diff 32810

View Options

CMakeLists.txt

Loading...
View Options

sddm-theme/theme.conf

Loading...
View Options

sddm-theme/theme.conf.cmake

Loading...