Give the "Clear History" button some text
AbandonedPublic

Authored by ngraham on Mar 14 2018, 3:13 AM.

Details

Reviewers
Fuchs
Group Reviewers
Plasma
Summary

The Notifications plasmoid recently gained a Clear History button in D11261! This patch gives the button some text so it's a bit clearer, since otherwise it's just a little clear button potentially in a sea of other clear buttons when there are a lot of notifications, which is precisely when you'd want to push it.

Test Plan

Diff Detail

Repository
R120 Plasma Workspace
Branch
clear-all-button-has-text (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
ngraham created this revision.Mar 14 2018, 3:13 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 14 2018, 3:13 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Mar 14 2018, 3:13 AM
ngraham edited the summary of this revision. (Show Details)Mar 14 2018, 3:15 AM
ngraham edited the test plan for this revision. (Show Details)
zzag added a subscriber: zzag.EditedMar 14 2018, 3:44 AM

Can another icon be used in the clear history button? The current one indicates that something is denied/prohibited. It causes confusion.

Or just get rid of it. Also, "clear history" doesn't quite fit for notifications. I suggest to use "clear" or "clear all".

Agreed! In the VDG room we discussed a broom, but unfortunately we don't have any such icon. If we got one, I'd be happy to use it. Until then, the only other option is a trash can (edit-delete-symbolic).

zzag added a comment.Mar 14 2018, 3:53 AM

Then get rid of it. It would cause only confusion :)

Get rid of what now?

zzag added a comment.Mar 14 2018, 4:11 AM

Get rid of what now?

The icon.

In general, buttons need icons, especially buttons that don't look like buttons until you hover over them, like this one. While I agree that a better icon would be preferable, since we don't have one, let's maybe keep the discussion on the subject of this patch (the text) and investigate adding a more appropriate icon elsewhere.

Fuchs added a comment.Mar 14 2018, 6:13 AM

Sorry, but clear -1 from me for the reasons outlined in the Telegram channel.

It looks cluttered, and with the very limited space in plasmoids it becomes unpredictable with translations.
It removes the very alignment that broulik and I worked hard to achieve.
It is inconsistent with the klipper plasmoid, which had that exact functionality for years, so I think we can live with it until we fixed the actual problem, which is "we need a better, more clear icon".

Fuchs requested changes to this revision.Mar 14 2018, 6:21 AM
This revision now requires changes to proceed.Mar 14 2018, 6:21 AM

Either remove the icon or put it on the right, then I wouldn't really mind this change.

Fuchs added a comment.Mar 14 2018, 2:48 PM

Either remove the icon or put it on the right, then I wouldn't really mind this change.

putting it on the right would make it inconsistent with every single plasma and KDE button I am aware of, so I'd still mind.

Removing the icon would make it inconsistent with the klipper plasmoid.

I still think the proper solution is to have a proper, understandable icon which is used consistently across plasmoids, either of the three changes would do the exact opposite of that.

broulik resigned from this revision.Mar 14 2018, 2:50 PM

Do whatever you want with this button.

Fuchs added a subscriber: broulik.Mar 14 2018, 2:58 PM

Do whatever you want with this button.

Okay, recommendation: due to all plasma buttons that have an icon having it on the left (see e.g.

) and klipper having a clear history functionality (see
) find a proper solution that works for both, e.g. an icon that is clear to understand, and then implement in both.

Until then: leave the clear notification history as is.

How about just "Clear" for the text? That should be short enough even in German, no? The word "history" is pretty redundant anyway.

And yeah, I agree that we need a better icon for these. For that, I've filed https://bugs.kde.org/show_bug.cgi?id=391855.

Fuchs added a comment.Mar 14 2018, 3:20 PM

How about just "Clear" for the text? That should be short enough even in German, no? The word "history" is pretty redundant anyway.

Actually the oppposite, if you only do "clear" it might become unclear in a few languages. I think the text is fine, really. I'd just prefer to have no text at all, consistent with the klipper one.

And yeah, I agree that we need a better icon for these. For that, I've filed https://bugs.kde.org/show_bug.cgi?id=391855.

Wonderful, thank you. I still think a broom might do, it's what tango does, it doesn't depend on position of to-be-cleared icons and it is rather cultural independent. But that's something to discuss there.

I'm afraid that I am going to be very strict on "have a solution that is consistent with the rest", so I will reject all proposed changes that are not consistent across the board, which includes, right now, any kind of text. Sorry. For once I'd love to have a global solution and not partial solutions in some and not in other places.
As in: I see it as a valid problem, but I don't see adding this change here as a solution, so I stay with "no"

Once we have a proper, recognizable icon I think we can use that in the cases named and do not need text, hopefully.

I agree that consistency is important! For that reason, I would propose adding text everywhere. Buttons without text are inherently ambiguous unless their icons are perfect (and even a broom icon doesn't quite get there IMHO, though it's better). I know designers hate excessive text, but users appreciate the clarity and obviousness of buttons with text.

Fuchs added a comment.Mar 14 2018, 3:32 PM

I agree that consistency is important! For that reason, I would propose adding text everywhere. Buttons without text are inherently ambiguous unless their icons are perfect (and even a broom icon doesn't quite get there IMHO, though it's better). I know designers hate excessive text, but users appreciate the clarity and obviousness of buttons with text.

I'm willing to nod off (even though there I have no say in it there) a patch which adds it to all places ( e.g. the klipper I linked) if reasonably sure that it works across languages (so we don't have half of text in some languages, which is arguably worse than no text at all), but I'd like to give a clear, recognizable icon a try first.

We have lots of other icons in plasmoids (close notifications, mute, copy, menu, ...) that work well without text, some of them also destructive actions, so I'd like to give that a try first for the sake of space and not-clutterednes.

I will comment on the clear-all bug and hope that something great comes out of this, then we can re-evaluate this one here :)

OK, sounds like a plan!

ngraham abandoned this revision.Tue, Jun 25, 9:18 PM