Fix font rendering for non-HiDPI and integer scale factors
ClosedPublic
Actions

Authored by ngraham on Mar 13 2018, 2:04 AM.

Details

Reviewers

mart
davidedmundson
broulik

Commits

R858:9a5f7d834f86: Fix font rendering for non-HiDPI and integer scale factors

Summary

QQC2-desktop-style was attempting to force the use of Text.QtRendering for non-integer scale factors. However, it was accidentally using it everywhere. This patch resolves the issue, and makes it use Text.QtRendering only for non-integer scale factors.

BUG: 391780
FIXED-IN: 5.45

Test Plan

No visual changes when there is a non-integer scale factor.

System Settings before, no scale factor:

System Settings after, no scale factor:

Discover before, no scale factor:

Discover after, no scale factor:

To notice the differences, you will probably have to open them in different tabs, zoom in with Meta++, and switch between the tabs.

Diff Detail

Repository

R858 Qt Quick Controls 2: Desktop Style

Branch

fix-font-rendering-for-non-hidpi-and-integer-scale-factors (branched from master)

Lint

No Linters Available

Unit

No Unit Test Coverage

ngraham created this revision.Mar 13 2018, 2:04 AM

Restricted Application added a project: Plasma. · View Herald TranscriptMar 13 2018, 2:04 AM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

ngraham requested review of this revision.Mar 13 2018, 2:04 AM

ngraham edited the test plan for this revision. (Show Details)Mar 13 2018, 2:07 AM

ngraham mentioned this in D11244: Fix text scaling with non-integer scale factors when PLASMA_USE_QT_SCALING=1 is set.Mar 13 2018, 2:08 AM

davidedmundson accepted this revision.Mar 13 2018, 11:09 AM

This revision is now accepted and ready to land.Mar 13 2018, 11:09 AM

mart accepted this revision.Mar 13 2018, 11:48 AM

Closed by commit R858:9a5f7d834f86: Fix font rendering for non-HiDPI and integer scale factors (authored by ngraham). · Explain WhyMar 13 2018, 1:39 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			org.kde.desktop/ComboBox.qml (5 lines)
M			org.kde.desktop/Label.qml (6 lines)
M			org.kde.desktop/TextArea.qml (6 lines)
M			org.kde.desktop/TextField.qml (6 lines)