Fix font rendering for non-HiDPI and integer scale factors
ClosedPublic

Authored by ngraham on Mar 13 2018, 2:04 AM.

Details

Summary

QQC2-desktop-style was attempting to force the use of Text.QtRendering for non-integer scale factors. However, it was accidentally using it everywhere. This patch resolves the issue, and makes it use Text.QtRendering only for non-integer scale factors.

BUG: 391780
FIXED-IN: 5.45

Test Plan

No visual changes when there is a non-integer scale factor.

System Settings before, no scale factor:

System Settings after, no scale factor:

Discover before, no scale factor:

Discover after, no scale factor:

To notice the differences, you will probably have to open them in different tabs, zoom in with Meta++, and switch between the tabs.

Diff Detail

Repository
R858 Qt Quick Controls 2: Desktop Style
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Mar 13 2018, 2:04 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 13 2018, 2:04 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Mar 13 2018, 2:04 AM
ngraham edited the test plan for this revision. (Show Details)Mar 13 2018, 2:07 AM
davidedmundson accepted this revision.Mar 13 2018, 11:09 AM
This revision is now accepted and ready to land.Mar 13 2018, 11:09 AM
mart accepted this revision.Mar 13 2018, 11:48 AM
This revision was automatically updated to reflect the committed changes.