Show all actions on the main Kirigami toolbar and use the secondary one only for status

Authored by ngraham on Mar 10 2018, 8:59 PM.



This is an alternative to D11214 and D11215, and a different method of fixing I rather prefer it.

The patches moves the Update All button onto the main Kirigami Toolbar, next to Check for Updates. This allows the secondary white-background toolbar to be used solely for communicating status information, so there is no longer any possibility of an overlap. It also improves the design IMHO, by putting all the action buttons in one place, and all the status information in another.

BUG: 391632

Test Plan

All updates selected:

Some updates not selected:

Diff Detail

R134 Discover Software Store
better-updates-page-toolbars (branched from master)
No Linters Available
No Unit Test Coverage
ngraham created this revision.Mar 10 2018, 8:59 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 10 2018, 8:59 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Mar 10 2018, 8:59 PM
ngraham edited the summary of this revision. (Show Details)Mar 10 2018, 9:04 PM
ngraham edited the test plan for this revision. (Show Details)
ngraham updated this revision to Diff 29193.Mar 10 2018, 9:36 PM

Remove another now-unnecessary thing

ngraham added a comment.EditedMar 10 2018, 9:44 PM

There is one bug: the Update button correctly becomes a Cancel button once you click it, but it's disabled:

I could use a hand fixing that, unless it's because Flatpak transactions aren't cancellable?

apol added a comment.Mar 12 2018, 11:46 AM

It looks to me like the Refresh action has more relevance here, which is odd.

Also the centered text looks weird now, maybe needs reconsideration too.


Why move to the center?

I thought the centered text looked better, but I can undo that.

I think the real issue here is that if I add a second action to contextualActions, they both appear under an overflow button, despite the fact that there's enough room on the toolbar to fit both of them.

ngraham updated this revision to Diff 29329.Mar 12 2018, 1:11 PM
  • Bring back left-justifies text in secondary toolbar
  • Add an icon for the refresh action
ngraham edited the test plan for this revision. (Show Details)Mar 12 2018, 1:13 PM
apol accepted this revision.Mar 12 2018, 3:26 PM
This revision is now accepted and ready to land.Mar 12 2018, 3:26 PM
ngraham marked an inline comment as done.Mar 12 2018, 3:55 PM
ngraham updated this revision to Diff 29368.Mar 13 2018, 2:17 AM

Rebase on master

ngraham closed this revision.Mar 13 2018, 2:18 AM