Differential D11215

Improve Updates page toolbar entries left and right padding
AbandonedPublic
Actions

Authored by ngraham on Mar 10 2018, 5:12 PM.

Details

Reviewers
apol
Group Reviewers
Discover Software Store
VDG
Summary

The Updates page has an internal toolbar whose entries have excessive left and right padding. This patch corrects it, so they have equal padding on all three sides, making the design look better.

Test Plan

Before:

After:

Diff Detail

Repository
R134 Discover Software Store
Branch
improve-updates-page-toolbar-buttons-padding (branched from Plasma/5.12)
Lint
No Linters Available
Unit
No Unit Test Coverage
ngraham created this revision.Mar 10 2018, 5:12 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 10 2018, 5:12 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Mar 10 2018, 5:12 PM
ngraham edited the test plan for this revision. (Show Details)Mar 10 2018, 5:14 PM
ngraham added a comment.Mar 10 2018, 9:18 PM

Possibly/likely superseded by D11218.

apol accepted this revision.Mar 12 2018, 12:00 PM
apol added a subscriber: apol.

I'm not sure why this is needed now. I guess it makes sense to have this in 5.12.

This revision is now accepted and ready to land.Mar 12 2018, 12:00 PM
ngraham abandoned this revision.Mar 13 2018, 2:18 AM

Abandoning in favor of D11218, which is a better approach.

Revision Contents
Changeset List

PathPackages
Mdiscover/qml/UpdatesPage.qml (4 lines)

Diff 29176

View Options

discover/qml/UpdatesPage.qml

Loading...