Differential D11214

Don't let the selection text overlap the Update button
AbandonedPublic
Actions

Authored by ngraham on Mar 10 2018, 4:37 PM.

Details

Reviewers
apol
Group Reviewers
Discover Software Store
Summary

By removing the "n unselected" text (which doesn't really add anything anyway), we ensure that the Update button is never overlapped.

If this isn't acceptable, an alternative approach might involve always showing the Update button in the toolbar.

BUG: 391632

Test Plan

At all window widths, the Update button is now never overlapped by the selection text.

Diff Detail

Repository
R134 Discover Software Store
Branch
never-overlap-update-button (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
ngraham created this revision.Mar 10 2018, 4:37 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 10 2018, 4:37 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Mar 10 2018, 4:37 PM
ngraham edited the summary of this revision. (Show Details)Mar 10 2018, 4:37 PM
ngraham added a reviewer: apol.
ngraham added a comment.Mar 10 2018, 9:18 PM

Possibly/likely superseded by D11218.

apol accepted this revision.Mar 12 2018, 12:31 AM
This revision is now accepted and ready to land.Mar 12 2018, 12:31 AM
ngraham added a comment.Mar 12 2018, 12:46 AM

So you prefer this one to D11218? Note that we do lose the "n updates not selected" text with this approach.

ngraham abandoned this revision.Mar 13 2018, 2:18 AM

Abandoning in favor of D11218, which is a better approach.

Revision Contents
Changeset List

PathPackages
Mdiscover/qml/UpdatesPage.qml (9 lines)

Diff 29174

View Options

discover/qml/UpdatesPage.qml

Loading...