Differential D11182

org.freedesktop.PowerManagement.Inhibit should only prevent suspend
ClosedPublic
Actions

Authored by broulik on Mar 9 2018, 3:47 PM.

Details

Reviewers
oliverhenshaw
davidedmundson
Group Reviewers
Plasma
Commits
R122:152400c1b688: org.freedesktop.PowerManagement.Inhibit should only prevent suspend
Summary

For preventing screen standby or screen locking the org.freedesktop.ScreenSaver.Inhibit must be used.
Both calls erroneously did the same.

Test Plan

Started a video in Chrome, got an inhibition for screen and suspend
Started audio player in Chrome, got an inhibition for suspend only
Started a download in Chrome, got an inhibition for suspend only
Started a video in VLC, got an inhibition for screen and suspend

Diff Detail

Repository
R122 Powerdevil
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Mar 9 2018, 3:47 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 9 2018, 3:47 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Mar 9 2018, 3:47 PM
davidedmundson accepted this revision.Mar 23 2018, 12:43 PM
davidedmundson added a subscriber: davidedmundson.

Given it's relying on other applications being sane, which is generally unreliable, maybe it's best to only put this in master.

This revision is now accepted and ready to land.Mar 23 2018, 12:43 PM
Closed by commit R122:152400c1b688: org.freedesktop.PowerManagement.Inhibit should only prevent suspend (authored by broulik). · Explain WhyMar 23 2018, 12:49 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mdaemon/powerdevilfdoconnector.cpp (4 lines)

Diff 30307

View Options

daemon/powerdevilfdoconnector.cpp

Loading...