oliverhenshaw (Oliver Henshaw)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Jun 28 2016, 7:42 PM (404 w, 2 d)
Availability
Available

Recent Activity

Apr 27 2017

oliverhenshaw added inline comments to D5606: Re-trigger lid action when lid is closed and external monitor is disconnected.
Apr 27 2017, 11:54 AM · Plasma

Dec 14 2016

oliverhenshaw added a comment to D3674: RFC: Allow pausing media players when screen is locked.

Surely the ideal world is one where the movie player realises the screen is locked and makes the decision to pause by itself? Media controls might still be a better option for audio players, but I wonder whether volume controls are better than that?

Dec 14 2016, 6:38 PM · Plasma

Oct 4 2016

oliverhenshaw committed R122:aa7c7560c213: Explain re-triggering lid close on profile change (authored by oliverhenshaw).
Explain re-triggering lid close on profile change
Oct 4 2016, 4:06 PM
oliverhenshaw closed D2934: Explain re-triggering lid close on profile change by committing R122:aa7c7560c213: Explain re-triggering lid close on profile change.
Oct 4 2016, 4:06 PM · Plasma
oliverhenshaw committed R120:713b921a7800: Use QLoggingCategory in ksmserver-logout-greeter (authored by oliverhenshaw).
Use QLoggingCategory in ksmserver-logout-greeter
Oct 4 2016, 4:00 PM
oliverhenshaw committed R120:1531c7688315: Improve ksmserver debug output (authored by oliverhenshaw).
Improve ksmserver debug output
Oct 4 2016, 4:00 PM
oliverhenshaw committed R120:84d9c3cd9c57: Use QLoggingCategory more in ksmerver (authored by oliverhenshaw).
Use QLoggingCategory more in ksmerver
Oct 4 2016, 4:00 PM
oliverhenshaw committed R120:72c1c5b5c315: Correct function name in startKilling debug output (authored by oliverhenshaw).
Correct function name in startKilling debug output
Oct 4 2016, 4:00 PM
oliverhenshaw closed D2935: Improve ksmserver debug output by committing R120:1531c7688315: Improve ksmserver debug output.
Oct 4 2016, 4:00 PM · Plasma
oliverhenshaw updated the diff for D2935: Improve ksmserver debug output.

Add patch 3 - Use QLoggingCategory in ksmserver-logout-greeter

Oct 4 2016, 2:49 PM · Plasma
oliverhenshaw updated the diff for D2935: Improve ksmserver debug output.

Add patch 2 - Use QLoggingCategory more in ksmerver

Oct 4 2016, 2:48 PM · Plasma
oliverhenshaw retitled D2935: Improve ksmserver debug output from to Improve ksmserver debug output.
Oct 4 2016, 2:46 PM · Plasma
oliverhenshaw added a reviewer for D2934: Explain re-triggering lid close on profile change: Plasma.
Oct 4 2016, 2:20 PM · Plasma
oliverhenshaw retitled D2934: Explain re-triggering lid close on profile change from to Explain re-triggering lid close on profile change.
Oct 4 2016, 2:14 PM · Plasma

Sep 12 2016

oliverhenshaw added a comment to D2033: Clear idle timeouts when session becomes inactive.

So, should we go with this patch then? Powerdevil is now a separate binary, so

IdleTime::instance()->removeAllIdleTimeouts();

shouldn't cause side-effects on other modules and also should fix it for non-weird X setups like mine. ;)

Sep 12 2016, 11:53 AM · Plasma

Sep 10 2016

oliverhenshaw committed R108:942f8f477090: Merge remote-tracking branch 'origin/KDE/4.10' into master (authored by oliverhenshaw).
Merge remote-tracking branch 'origin/KDE/4.10' into master
Sep 10 2016, 6:24 AM
oliverhenshaw committed R108:635d7da00541: Replace foreach with java-style iterator (authored by oliverhenshaw).
Replace foreach with java-style iterator
Sep 10 2016, 6:24 AM
oliverhenshaw committed R108:4475d8079d85: add qml import paths in correct order (authored by oliverhenshaw).
add qml import paths in correct order
Sep 10 2016, 6:24 AM
oliverhenshaw committed R108:12cca1499288: Drop unneeded duplicate addImportPath (authored by oliverhenshaw).
Drop unneeded duplicate addImportPath
Sep 10 2016, 6:24 AM
oliverhenshaw committed R108:dbbd536ead9c: Merge remote-tracking branch 'origin/KDE/4.10' into master (authored by oliverhenshaw).
Merge remote-tracking branch 'origin/KDE/4.10' into master
Sep 10 2016, 6:23 AM
oliverhenshaw committed R106:c2d3c4075f48: Merge remote-tracking branch 'origin/KDE/4.10' into master (authored by oliverhenshaw).
Merge remote-tracking branch 'origin/KDE/4.10' into master
Sep 10 2016, 3:58 AM

Aug 10 2016

oliverhenshaw added a comment to D2033: Clear idle timeouts when session becomes inactive.

So, what should we do with this? Since we now have powerdevil as a separate binary we could savely do

KIdleTime::instance()->removeAllIdleTimeouts();

without jeopardizing other kded modules.

Aug 10 2016, 12:01 PM · Plasma
oliverhenshaw added reviewers for D2393: Don't check current active session at all: Plasma, broulik.
Aug 10 2016, 11:56 AM · Plasma
oliverhenshaw reopened D2325: Don't unconditionally emit buttonPressed on profile load.

I can't find any evidence about the reason this was put in there in the first place.

Aug 10 2016, 11:18 AM · Plasma

Jul 13 2016

oliverhenshaw requested changes to D2033: Clear idle timeouts when session becomes inactive.

I may not have much pull, but I'd rather these changes were revised again before being landed. Sorry!

Jul 13 2016, 6:39 PM · Plasma

Jun 28 2016

oliverhenshaw added inline comments to D2033: Clear idle timeouts when session becomes inactive.
Jun 28 2016, 9:42 PM · Plasma
oliverhenshaw added a comment to D2033: Clear idle timeouts when session becomes inactive.

Cancelling all timeouts set by powerdevil when the session becomes inactive is probably the right thing to do here.

Jun 28 2016, 8:08 PM · Plasma