Differential D11129

Mark kpackage_install_package undeprecated for plasma_install_package
ClosedPublic
Actions

Authored by kossebau on Mar 7 2018, 3:07 PM.

Details

Reviewers
mart
apol
Commits
R290:8c7f78206b95: Mark kpackage_install_package undeprecated for plasma_install_package
Summary

While no-one is working on porting plasma_install_package away from
kpackage_install_package, and given this results in long logs of
deprecation warnings for Plasma repo, for now enable
plasma_install_package to disable the deprecation warning with a
undocumented flag.

Diff Detail

Repository
R290 KPackage
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.Mar 7 2018, 3:07 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 7 2018, 3:07 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
kossebau requested review of this revision.Mar 7 2018, 3:07 PM
apol added inline comments.Mar 8 2018, 5:23 PM
KF5PackageMacros.cmake
27

How about if(KF5Plasma_FIND_VERSION VERSION_LESS 5.43.0)?

This way it's only shown on projects that are actually depending on the new version. And if they are well then that's fine to have the warning.

kossebau added inline comments.Mar 8 2018, 5:32 PM
KF5PackageMacros.cmake
27

This won't have any effect, given this will be always true for people which use this version as it is coming with all the other KF5 modules, no?

The problem is this:
as applet developer you have no choice but to use plasma_install_package. And you have no control about what it is doing, e.g. that it is using this other macro which spits out the warning. So the package-system developers internal reminder to complete this task gets written out to all the other developers, who just innocently use this macro.

mart accepted this revision.Mar 8 2018, 5:40 PM
This revision is now accepted and ready to land.Mar 8 2018, 5:40 PM
Closed by commit R290:8c7f78206b95: Mark kpackage_install_package undeprecated for plasma_install_package (authored by kossebau). · Explain WhyMar 8 2018, 9:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MKF5PackageMacros.cmake (5 lines)

Diff 29043

View Options

KF5PackageMacros.cmake

Loading...