Differential D11102

[Dialog] Allow setting outputOnly for NoBackground dialog
ClosedPublic
Actions

Authored by broulik on Mar 6 2018, 9:47 PM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R242:049aa5677de3: [Dialog] Allow setting outputOnly for NoBackground dialog
Summary

I don't see why this would be silently discarded. The input shape has nothing to do with the window mask (e.g. rounded border depending on theme).

Test Plan
  • Created a dialog with NoBackground and instead a fully custom background and made it click-through successfully
  • Changing the property at runtime still update sfine
  • OSD is still click-through as before

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Mar 6 2018, 9:47 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 6 2018, 9:47 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
broulik requested review of this revision.Mar 6 2018, 9:47 PM
mart accepted this revision.Mar 15 2018, 12:06 PM
This revision is now accepted and ready to land.Mar 15 2018, 12:06 PM
Closed by commit R242:049aa5677de3: [Dialog] Allow setting outputOnly for NoBackground dialog (authored by broulik). · Explain WhyMar 15 2018, 12:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/plasmaquick/dialog.cpp (4 lines)

Diff 29590

View Options

src/plasmaquick/dialog.cpp

Loading...