| graesslin | |
| albertvaka |
| KDE Connect |
The MousepadPlugin contains disjoint codepaths to support X11 and Wayland. Split it into two plugins instead of #ifdef'ing for better maintainability.
Currently both plugins are loaded (when compiled). Is there a way to decide whether to load them on runtime? On Android I just would return false in onCreate, but there seems no aquivalent on the desktop.
Tested on X and Wayland.
X works fine, Wayland plugin on Wayland too.
X plugin on Wayland crashes, needs to be disabled on runtime.
| No Linters Available |
| No Unit Test Coverage |
Would it make sense to have a small input method abstraction class within the plugin?
Would also solve the duplicated plugin issue.
| plugins/mousepad_wayland/mousepadplugin_wayland.cpp | ||
|---|---|---|
| 34 | I'd say it's barely better maintainability when stuff is duplicated. | |
I don't like having two plugins doing the same. I really like removing the ifdefs, though, and having code for each platform on a different file. Can we do this inside a same plugin?
We could have a mousepadplugin that instantiates one specific implementation class within it, depending on the platform (wayland/X11/windows/macosx/whatever), instead of N different plugins.