Differential D11692

Split platform-specific code from mousepad plugin
ClosedPublic
Actions

Authored by albertvaka on Mar 25 2018, 5:14 PM.

Tags

Subscribers

apol, nicolasfella

Details

Reviewers

apol
nicolasfella

Group Reviewers

Commits

R224:f1f19eb01b8e: Split platform-specific code from mousepad plugin

Summary

Windows no longer needs a separate plugin, and X11 and Wayland are now in
separate files instead of having lots of ifdefs.

Test Plan

Tested on X11, Wayland and Windows.

Diff Detail

Repository

R224 KDE Connect

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

albertvaka requested review of this revision.Mar 25 2018, 5:14 PM

albertvaka created this revision.

nicolasfella mentioned this in D10779: Split MousepadPlugin into X11 and Wayland plugin.Mar 25 2018, 5:14 PM

nicolasfella added a subscriber: nicolasfella.Mar 26 2018, 11:41 AM

nicolasfella added inline comments.

plugins/CMakeLists.txt
14	Does ! work thee same as NOT?

Restricted Application added a project: KDE Connect. · View Herald TranscriptMar 26 2018, 11:41 AM

Looks good to me, please fix Nico's comment before landing.

This revision now requires changes to proceed.Mar 27 2018, 11:07 PM

Fixed CMake syntax.

plugins/CMakeLists.txt
14	No, it didn't :)

nicolasfella accepted this revision.Apr 2 2018, 7:01 PM

apol accepted this revision.Apr 4 2018, 11:19 AM

This revision is now accepted and ready to land.Apr 4 2018, 11:19 AM

Closed by commit R224:f1f19eb01b8e: Split platform-specific code from mousepad plugin (authored by albertvaka). · Explain WhyApr 4 2018, 8:38 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			plugins/CMakeLists.txt (6 lines)
M			plugins/mousepad/CMakeLists.txt (43 lines)
P			plugins/mousepad/abstractremoteinput.h (20 lines) Copied from plugins/mousepad_windows/mousepadplugin_windows.h
P			plugins/mousepad/abstractremoteinput.cpp (24 lines) Copied from plugins/mousepad_windows/mousepadplugin_windows.h
M			plugins/mousepad/config-mousepad.h.cmake (1 line)
M			plugins/mousepad/mousepadplugin.h (33 lines)
P			plugins/mousepad/mousepadplugin.cpp (325 lines) Copied to plugins/mousepad/x11remoteinput.cpp
P			plugins/mousepad/waylandremoteinput.h (33 lines) Copied from plugins/mousepad_windows/mousepadplugin_windows.h
A	M		plugins/mousepad/waylandremoteinput.cpp (103 lines)
P			plugins/mousepad/windowsremoteinput.h (21 lines) Copied from plugins/mousepad_windows/mousepadplugin_windows.h
V			plugins/{mousepad/windowsremoteinput.cpp ← mousepad_windows/mousepadplugin_windows.cpp} (24 lines)
V			plugins/{mousepad/x11remoteinput.h ← mousepad_windows/mousepadplugin_windows.h} (25 lines)
P			plugins/mousepad/x11remoteinput.cpp (144 lines) Copied from plugins/mousepad/mousepadplugin.cpp
D	M		plugins/mousepad_windows/CMakeLists.txt (2 lines)
D	M		plugins/mousepad_windows/kdeconnect_mousepad.json (96 lines)
P			plugins/mousepad_windows/mousepadplugin_windows.h Deleted after being copied to multiple locations: plugins/mousepad/abstractremoteinput.cpp plugins/mousepad/abstractremoteinput.h plugins/mousepad/waylandremoteinput.h plugins/mousepad/windowsremoteinput.h plugins/mousepad/x11remoteinput.h
V			plugins/{mousepad_windows/mousepadplugin_windows.cpp → mousepad/windowsremoteinput.cpp}

Diff 31326

plugins/CMakeLists.txt

Loading...

plugins/mousepad/CMakeLists.txt

Loading...

plugins/mousepad/abstractremoteinput.h

Loading...

plugins/mousepad/abstractremoteinput.cpp

Loading...

plugins/mousepad/config-mousepad.h.cmake

Loading...

plugins/mousepad/mousepadplugin.h

Loading...

plugins/mousepad/mousepadplugin.cpp

Loading...

plugins/mousepad/waylandremoteinput.h

Loading...

plugins/mousepad/waylandremoteinput.cpp

Loading...

plugins/mousepad/windowsremoteinput.h

Loading...

plugins/mousepad/windowsremoteinput.cpp

Loading...

plugins/mousepad/x11remoteinput.h

Loading...

plugins/mousepad/x11remoteinput.cpp

Loading...

plugins/mousepad_windows/CMakeLists.txt

Loading...

plugins/mousepad_windows/kdeconnect_mousepad.json

Loading...

plugins/mousepad_windows/mousepadplugin_windows.h

Loading...

plugins/mousepad_windows/mousepadplugin_windows.cpp

Loading...