[AppletAppearance] Remove d QtObject
ClosedPublic

Authored by broulik on Feb 16 2018, 9:25 AM.

Details

Summary

It's not like this is public API or anything.

Test Plan

Saves one QObject per applet.
Moving applets still works and is saved correctly, no warnings on console.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Feb 16 2018, 9:25 AM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 16 2018, 9:25 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Feb 16 2018, 9:25 AM
davidedmundson accepted this revision.Mar 5 2018, 11:11 AM
This revision is now accepted and ready to land.Mar 5 2018, 11:11 AM
mart accepted this revision.Mar 5 2018, 12:57 PM
mart added a subscriber: mart.

the concern is that now applets have a codepath to access it by going to see their parents...
but is something they should never ever do, so good to go for me

apol added a subscriber: apol.Mar 5 2018, 3:04 PM
In D10571#219016, @mart wrote:

the concern is that now applets have a codepath to access it by going to see their parents...
but is something they should never ever do, so good to go for me

If this is a concern, these properties can be set on the Timer...

This revision was automatically updated to reflect the committed changes.