Differential D10566

Fictionbook: Add support for code, superscript, & subscript tags
ClosedPublic
Actions

Authored by abogical on Feb 16 2018, 2:08 AM.

Details

Reviewers
aacid
Group Reviewers
Okular
Commits
R223:ce7fa7b9d879: Fictionbook: Add support for code, superscript, & subscript tags
Summary

BUG: 387426

Test Plan

Open a book with the code, superscript, & subscript tags. Verify that the code is visible in a mono-space font, & superscripts & subscripts are formatted appropriately.

Diff Detail

Repository
R223 Okular
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
abogical created this revision.Feb 16 2018, 2:08 AM
Restricted Application added a project: Okular. · View Herald TranscriptFeb 16 2018, 2:08 AM
abogical requested review of this revision.Feb 16 2018, 2:08 AM
ngraham added a subscriber: ngraham.Feb 16 2018, 2:58 AM

Thanks for your patch! For the summary section, please see https://community.kde.org/Infrastructure/Phabricator#Formatting_your_patch for information about how to format the BUG: tag to connect this patch with the Bugzilla ticket.

cfeck added a subscriber: cfeck.EditedFeb 16 2018, 4:54 AM

Thanks for the patch!

Please adjust the spaces around parens to follow the surrounding code.

Bonus points if you also add the missing support for 'sup' and 'sub', as investigated in the bug ticket.

abogical updated this revision to Diff 27335.Feb 16 2018, 12:04 PM
abogical edited the test plan for this revision. (Show Details)

Added support for superscript and subscript tags, also fixed formatting issues. Just a question, what tools does the KDE developers use for linting the formatting of their code?

abogical retitled this revision from Add support for code tags in fictionbook to Add support for code, superscript, & subscript tags in fictionbook.Feb 16 2018, 12:05 PM
abogical retitled this revision from Add support for code, superscript, & subscript tags in fictionbook to Fictionbook: Add support for code, superscript, & subscript tags.Feb 16 2018, 12:14 PM
abogical edited the summary of this revision. (Show Details)
abogical edited the test plan for this revision. (Show Details)Feb 16 2018, 12:18 PM
abogical updated this revision to Diff 27376.Feb 16 2018, 8:49 PM
This comment was removed by abogical.
abogical updated this revision to Diff 27378.Feb 16 2018, 8:52 PM

Use QStringLiteral .

aacid added a subscriber: aacid.Feb 18 2018, 9:15 PM
In D10566#207668, @abogical wrote:

Just a question, what tools does the KDE developers use for linting the formatting of their code?

there's no general linting solution, in particular we don't use anything in okular

aacid accepted this revision.Feb 18 2018, 9:21 PM

Looks reasonable.

This revision is now accepted and ready to land.Feb 18 2018, 9:21 PM
aacid added a comment.Feb 18 2018, 9:24 PM

We're going to need your name before being able to commit this.

abogical added a comment.EditedFeb 18 2018, 10:01 PM

Name is Abdel-Rahman A.

aacid added a comment.Feb 18 2018, 10:04 PM

is your surname really "A." ?

abogical added a comment.Feb 18 2018, 10:05 PM

Full name is 'Abdel-Rahman Abdel-Rahman'. but I just like to hide my last name.

aacid closed this revision.Feb 18 2018, 10:27 PM
Closed by commit R223:ce7fa7b9d879: Fictionbook: Add support for code, superscript, & subscript tags (authored by abogical, committed by aacid). · Explain WhyFeb 18 2018, 10:27 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 27499

View Options

generators/fictionbook/converter.h

Loading...
View Options

generators/fictionbook/converter.cpp

Loading...