Details
Details
Diff Detail
Diff Detail
- Repository
- R243 KArchive
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
autotests/karchivetest.cpp | ||
---|---|---|
1169 | Maybe do a directory listing too, to check if the duplicate name appears twice? |
Comment Actions
Thanks - almost there.
autotests/karchivetest.cpp | ||
---|---|---|
1172 | This detaches the list, put it in a const local variable. (standard range-for trap with Qt containers) |
Comment Actions
This comment has been deleted.
autotests/karchivetest.cpp | ||
---|---|---|
1172 | the performance impact here was negligible so I preferred to keep the code simpler, but changed it now |
Comment Actions
Yeah but good practice is better applied everywhere, to avoid showing bad examples to others ;)
Thanks.