Revert "reserve space for checkable widgets in menu items"

Authored by zzag on Feb 15 2018, 9:25 AM.

Diff Detail

R31 Breeze
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Feb 15 2018, 9:25 AM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 15 2018, 9:25 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
zzag requested review of this revision.Feb 15 2018, 9:25 AM
hpereiradacosta accepted this revision.Feb 15 2018, 10:42 AM

Thanks for considering my hesitations on this.
I do think this change is either not mature or not needed and should be reverted.

This revision is now accepted and ready to land.Feb 15 2018, 10:42 AM
This revision was automatically updated to reflect the committed changes.
rkflx added a subscriber: rkflx.Feb 15 2018, 11:16 AM


FWIW, I support this revert. I think introducing this was more of a misunderstanding in relation to being used to a particular look, because by default in Windows (and elsewhere) there are almost no icons in menus, so you are used to this look:

In KDE's software icons are much more prevalent, so you have less empty space. However, note that in the Windows screenshot (and on other platforms too) icons are in place of the empty space, while your patch added extra empty space next to the icons (i.e. more extreme than Windows).

In my book, adding extra space only when required for checkboxes (like we did before the patch) is just fine.