This reverts commit 8989f8fd9c2c98adec5d73755a869beeb3ced600.
Details
- Reviewers
hpereiradacosta - Group Reviewers
Breeze - Commits
- R31:4bad99624bd7: Revert "reserve space for checkable widgets in menu items"
Diff Detail
- Repository
- R31 Breeze
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Thanks for considering my hesitations on this.
I do think this change is either not mature or not needed and should be reverted.
+1
FWIW, I support this revert. I think introducing this was more of a misunderstanding in relation to being used to a particular look, because by default in Windows (and elsewhere) there are almost no icons in menus, so you are used to this look:
In KDE's software icons are much more prevalent, so you have less empty space. However, note that in the Windows screenshot (and on other platforms too) icons are in place of the empty space, while your patch added extra empty space next to the icons (i.e. more extreme than Windows).
In my book, adding extra space only when required for checkboxes (like we did before the patch) is just fine.