Make KUndo2Stack::push return false if the command was merged (and deleted) rather than pushed
ClosedPublic
Actions

Authored by staniek on Feb 28 2016, 4:40 PM.

Details

Reviewers

Commits

Summary

This helps to know if the command object can be still accessed after the call.

Backported from kexi.git master.

Repository

R8 Calligra

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

staniek retitled this revision from to Make KUndo2Stack::push return false if the command was merged (and deleted) rather than pushed.

staniek updated this object.

staniek edited the test plan for this revision. (Show Details)

Looks good to me.

P.S. We probably need to share the kundo2 library between Kexi, Krita and Calligra.

This revision is now accepted and ready to land.Mar 27 2016, 10:58 AM

This revision was automatically updated to reflect the committed changes.

In D1032#23331, @aspotashev wrote:

Looks good to me.

P.S. We probably need to share the kundo2 library between Kexi, Krita and Calligra.

Thanks Alexander. Yes, this, or we would replace with Qt5 if there's equivalent. Research on that is still a TODO.

			Path	Packages
M			libs/kundo2/kundo2stack.h (2 lines)
M			libs/kundo2/kundo2stack.cpp (9 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	2484	f5eb0c9		Feb 28 2016, 4:40 PM	★	★
Diff 2	2977	ad8223e	rCALLIGRA68ac8207a9cf2a833aee6c6f3ede8755d39f84c8	Mar 27 2016, 9:50 PM	★	★