FEATURE: 389880
FIXED-IN: 5.44
Details
- Reviewers
markg - Group Reviewers
Frameworks - Commits
- R241:0792ed68923b: Use F11 as the shortcut to toggle the aside preview
Shortcut works and toggles the aside preview.
Diff Detail
- Repository
- R241 KIO
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage
+1 for the idea, just a question about the key.
Windows uses ALT+P: https://lifehacker.com/5811238/quickly-show-the-preview-pane-in-windows-7-with-alt-%252B-p
I don't know what Finder uses, you can probably tell ;)
As it stands now, i'd go for ALT+P. It also feels more logical due to the "P" in there for "Preview", which is exactly what it's going to show when pressed.
I use F11 to be consistent with Dolphin, where F11 toggles the information panel. It's not exactly the same thing, but I figured re-using existing KDE muscle memory was worthwhile. Alt-P could work too though, and would probably conflict less. Easier to type on a laptop with shared function keys, too.
Any ideas on the "ambiguous shortcut" issue?
Ah right!
Oke, i guess now is the moment to choose.
- Consistency with Dolphin (go for F11)
- Consistency with Windows Explorer (go for ALT + P and change the dolphin one default to ALT + P)
I'm fine with both options as long as there is consistency.
Accepting this one just in case you wont to go for option 1 :)
I have no clue for the ambiguous shortcut issue.
Fixed it!
Changing Dolphin to Alt-P would open a can of worms since the other panels are triggered with Function keys, so I think F11 makes sense here.
Interesting, it seems that phabricator updated the link to the commit, but did not close the bug. Let's ignore it, unless it happens again.
I'm a little bit late to the party, but F11is kind of the standard key for fullscreen.
Yeah, and Dolphin already overloads that by using F11 to show and hide the Information panel. I wouldn't object to using a different keyboard shortcut, but then we'd want to do it for all of for Dolphin's panels, and change the shortcuts here, too, which currently match Dolphin's.
my suggestion would be changing Dolphin's shortcut. If you use F11 it's unexpected if the window does not go to fullscreen. Even for dolphin a fullscreen shortcut might make sense. And in the case of fullscreen: Firefox defined that as the default. We have to accept that ;-)