Fix being unable to close the toolbox menu by clicking outside
Needs ReviewPublic

Authored by hein on Feb 3 2018, 3:12 AM.

Details

Reviewers
mart
Group Reviewers
Plasma
Summary

This also sort of broke using ESC to close, because that's what
users try next, but after clicking on the desktop the dialog no
longer has focus.

I examined the revision that introduced this change (e635931e4)
but saw no good reason for it. It was likely accidental.

Diff Detail

Repository
R119 Plasma Desktop
Branch
Plasma/5.12
Lint
No Linters Available
Unit
No Unit Test Coverage
hein created this revision.Feb 3 2018, 3:12 AM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 3 2018, 3:12 AM
hein requested review of this revision.Feb 3 2018, 3:12 AM

Can you verify the toolbox stays open while interacting with applets? If so, +1, otherwise this defies the purpose of the "edit mode" but I trust you tested exactly this :)

mart added a comment.Feb 6 2018, 10:07 AM

opening the toolbox enables an "edit mode" which opens all applet handles, they should continue to be interactible, so hideOnWindowDeactivate is probably not going to be enough, but would need more complex interaction (ie the desktop containment itself closing it when clicking on an epmpty area and probably when the desktop window loses focus

mart added a comment.Feb 6 2018, 10:24 AM

update: for me on master the toolbox menu is already closed both when clicking on an empty desktop area or another window, but not the applet handles or borders, as it should

hein added a comment.Feb 6 2018, 10:25 AM

Empty desktop doesn't close it for me without this patch.

This was based on a user bug report. It was almost the first thing they saw / struggled with when using Plasma for the first time.

mart added a comment.Mar 23 2018, 2:55 PM

still can't reproduce the popup not closing when clicking on empty areas of desktop, does the problem persists for you?

ngraham added a subscriber: ngraham.Jan 2 2019, 9:02 PM

Cannot reproduce the issue myself with either Folder View or Desktop. There must be some case where it's reproducible though...

GB_2 added a subscriber: GB_2.Sep 28 2019, 7:56 AM

Can be abandoned because of D24265.