Thanks for the patch! But what, no screenshot!? :) For visual changes like this, it's considered best practice to attach one. You can just drag-and-drop right into the Summary text field.

Sorry! Just created an account to submit this, still figuring things out. Here's a screen, with some context!

No worries! I like that icon, looks great. Could you maybe also attach another screenshot that shows it a bit larger, all on its own?

Also, let's add some reviewers! Breeze is the theme you're submitting this for, and VDG is our Visual Design Group, whose members tend to be interested in this sort of thing.

Done!

Sure!

.. Let me just figure that out first 😅

Or you can do it for me! Thanks :)

I did it for you this time. The "Add Action..." combobox above the comments field is used to do things like that.

Thanks Graham! I'll get the hang of this soon enough.

I'll look at it!

I just need to figure out how to diff between to commits first.

I like it! Maybe a way to accentuate that this is an "E" a little more. As a first impression, it didn't strike me as an E for emacs. Overall, the colors are great and the circle shape fits well.

Yeah, @abetts is right. Maybe reduce the size of the little flourishes on the top and bottom a bit?

I like it too. How does the 16px version look?

Just saw. There is none. Then how does it look in 16px size=

Here's a slightly altered version that should be more "E for Emacs"

As for a 16px version; It didnt cross my mind. Should I make one?

Here is a 16px version of the new icon. @lshoravi's revised version looks even better, and works well at any size. Well done!

Beautiful.

Oops, is this the right diff? You want to generate a diff against the existing icon, not against your previous commit.`git diff HEAD^^ will generate a diff from what you have (HEAD) to two commits back (^^)

In general, arcanist makes this process much easier, FWIW. https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist

I'm still figuring things out, haha 😅 Give me a minute and I'll figure it out

No worries! We've all been there. :)

Great! Would you mind updating the images in the Summary section to reflect your most recent changes?

Done and done!

The diff for this one applies sanely, so I think it's ready to land unless other folks would like changes (I'll wait for a while to give them time to take a look). In order to land the patch, we need a real name and email address. If Linus Shoravi is your real name, all we need is an email address and we're all set!

Alright, should I submit in some kind of form or just in a plain comment?

name: Linus Shoravi

@: linusshoravi@gmail.com

That's fine for now. Since this patch wasn't created using arcanist, I'll have to manually apply the name and email anyway. Once we get you set up with arcanist, neither of us will have to do this anymore!