use kcrash so we get drkonqi to pop up on crashes
ClosedPublic
Actions

Authored by sitter on Jan 29 2018, 2:04 PM.

Details

Reviewers

mart
bshah
davidedmundson

Commits

R124:9bb8a5f1412d: use kcrash so we get drkonqi to pop up on crashes

Test Plan

kill -SEGV pidof systemsettings5 brings up drkonqi

Diff Detail

Repository

R124 System Settings

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

sitter created this revision.Jan 29 2018, 2:04 PM

Restricted Application added a project: Plasma. · View Herald TranscriptJan 29 2018, 2:04 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

sitter requested review of this revision.Jan 29 2018, 2:04 PM

bshah accepted this revision.Jan 29 2018, 2:07 PM

This revision is now accepted and ready to land.Jan 29 2018, 2:07 PM

> kill -SEGV pidof systemsettings5 brings up drkonqi

That happens without this patch

In D10175#197736, @davidedmundson wrote:
>   kill -SEGV pidof systemsettings5 brings up drkonqi
That happens without this patch

interesting, doesn't happen for me.... it just coredumps to systemd-coredump for me

In D10175#197736, @davidedmundson wrote:
>   kill -SEGV pidof systemsettings5 brings up drkonqi
That happens without this patch

vokoscreen-2018-01-29_15-38-29.mkv3 MBDownload

heh, open the look and feel KCM and then it does.

Weird.

In D10175#197772, @davidedmundson wrote:

heh, open the look and feel KCM and then it does.

Weird.

kcrash is initialized as qcoreapp_startup thingy as well, so loading any plugin/kcm that already directly links against KCrash would enable kcrash. There was a thread about this a couple years ago on frameworks-devel which is around the time dfaure introduced the ::initalize function so apps can actively pull in kcrash.

Closed by commit R124:9bb8a5f1412d: use kcrash so we get drkonqi to pop up on crashes (authored by sitter). · Explain WhyJan 29 2018, 3:24 PM

This revision was automatically updated to reflect the committed changes.