Differential D10166

Add -Wlogical-op -Wzero-as-null-pointer-constant to KF5 warnings
ClosedPublic
Actions

Authored by aacid on Jan 28 2018, 9:03 PM.

Details

Reviewers
krop
apol
Commits
R240:60cb4b74bce8: Add -Wlogical-op -Wzero-as-null-pointer-constant to KF5 warnings

Diff Detail

Repository
R240 Extra CMake Modules
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
aacid created this revision.Jan 28 2018, 9:03 PM
Restricted Application added projects: Frameworks, Build System. · View Herald TranscriptJan 28 2018, 9:03 PM
Restricted Application added subscribers: Build System, Frameworks. · View Herald Transcript
aacid requested review of this revision.Jan 28 2018, 9:03 PM
dhaumann added a subscriber: dhaumann.Jan 28 2018, 9:31 PM

+1, but someone else must approve.

krop added a subscriber: krop.Jan 29 2018, 8:03 AM

These flags are not in the Clang warnings (list for each version here: https://github.com/Barro/compiler-warnings)

aacid added a comment.Feb 1 2018, 6:35 PM

-Wzero-as-null-pointer-constant does exist here, you're right the other one doesn't

I'll try to get this fixed once i recover for the havoc caused by my hd dying

aacid planned changes to this revision.Mar 4 2018, 5:53 PM
aacid updated this revision to Diff 36684.Jun 26 2018, 1:41 PM

make logical-op gcc only

Restricted Application edited subscribers, added: kde-buildsystem, kde-frameworks-devel; removed: Frameworks, Build System. · View Herald TranscriptJun 26 2018, 1:41 PM
krop accepted this revision.Jun 26 2018, 2:13 PM
This revision is now accepted and ready to land.Jun 26 2018, 2:13 PM
krop added a comment.Jun 26 2018, 2:15 PM

Thanks, just remove the trailing space before the 2 closing parenthesis.

apol added a subscriber: apol.Jun 27 2018, 8:56 AM
kde-modules/KDEFrameworkCompilerSettings.cmake
70–76

Maybe you can add -Wzero-as-null-pointer-constant to the if above which is gcc or clang?

aacid added inline comments.Jun 27 2018, 9:09 PM
kde-modules/KDEFrameworkCompilerSettings.cmake
70–76

problem it's i also need the version check and since we already have it here it doesn't make the code any more simpler.

apol accepted this revision.Jun 27 2018, 9:41 PM
apol added inline comments.
kde-modules/KDEFrameworkCompilerSettings.cmake
70–76

Ugh true, sorry.

Closed by commit R240:60cb4b74bce8: Add -Wlogical-op -Wzero-as-null-pointer-constant to KF5 warnings (authored by aacid). · Explain WhyJun 29 2018, 10:10 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 36880

View Options

kde-modules/KDEFrameworkCompilerSettings.cmake

Loading...