| broulik | |
| ngraham |
| Plasma: Workspaces | |
| Plasma |
BUG: 385097
This revision further improves the quality of images in notifications that was addressed in revision D9993. When I first looked into this, I tried setting ScaleType on the PreviewJob but it had no effect. I found that the preview images were being scaled to the small vertical size that was requested, and this resulted in my first revision. I should have tried setting ScaleType in addition.
Notification with unpatched libnotificationshelperplugin.so
Notification with patch applied
Take screenshot with Spectacle with unpatched libnotificationshelperplugin.so installed and observe the blurry preview image in the notification.
Install the patched libnotificationshelperplugin.so and restart plasmashell.
Take another screenshot with Spectacle and observe the much improved quality of the preview image in the notification.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
This revision was not accepted when it landed; it landed in state
For benefit of paperwork, it is implicitly accepted by me, I just didn't click the button before merging.