Further improve quality of images in notifications

Authored by rkron on Jan 28 2018, 9:17 PM.

Description

Further improve quality of images in notifications

BUG: 385097

This revision further improves the quality of images in notifications
that was addressed in revision D9993. When I first looked into this, I
tried setting ScaleType on the PreviewJob but it had no effect. I found
that the preview images were being scaled to the small vertical size
that was requested, and this resulted in my first revision. I should
have tried setting ScaleType in addition.

Notification with unpatched libnotificationshelperplugin.so

Notification with patch applied

Test Plan:
Take screenshot with Spectacle with unpatched
libnotificationshelperplugin.so installed and observe the blurry
preview image in the notification.

Install the patched libnotificationshelperplugin.so and restart
plasmashell.

Take another screenshot with Spectacle and observe the much improved
quality of the preview image in the notification.

Reviewers: Plasma: Workspaces, Plasma, broulik, ngraham

Subscribers: Plasma, Plasma: Workspaces, plasma-devel, broulik, ngraham

Tags: Plasma, Spectacle

Differential Revision: https://phabricator.kde.org/D10146

Details

Committed
davidedmundsonJan 28 2018, 9:18 PM
Differential Revision
D10146: Further improve quality of images in notifications (Bug 385097)
Parents
R120:1cb0d180bdda: Fix autohide panels on wayland
Branches
Unknown
Tags
Unknown