Relocate the Baloo database to the XDG cache location.
Needs ReviewPublic

Authored by smithjd on Jan 25 2018, 9:25 PM.

Details

Reviewers
None
Group Reviewers
Baloo
Summary

If the database exists in the old XDG Data location, migrate it to the XDG cache location.

Diff Detail

Repository
R293 Baloo
Branch
master-xdgCache (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
smithjd created this revision.Jan 25 2018, 9:25 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 25 2018, 9:25 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
smithjd requested review of this revision.Jan 25 2018, 9:25 PM
ngraham added a subscriber: michaelh.

This is a follow up of https://git.reviewboard.kde.org/r/129605/ (and the related discussion)

FWIW I'm in favor of this. XDG_CACHE_HOME seems appropriate since the data is easily regenerate-able, and we try to move the existing DB to the new location to prevent a re-index.

The way I use baloo the DB is not easily recreated at all.

  1. Indexing takes around 2hrs.
  2. On top of that I have to make a lot of manual adjustments due some bugs in baloo. That takes about another hour.

In my view a cache is for faster access of data that already exist somewhere else. "non-essential" data as freedesktop Standard states. The baloo db, though recreatable, definitely is essential data and as such belongs to XDG_DATA_HOME.

Putting something into XDG_CACHE_HOME is communicating to the users. "You can delete these data without harm".
At least in my case that is not true.

IMO the db should stay at its current location.

michaelh added a project: Baloo.