Add option to sort for original date
ClosedPublic
Actions

Authored by xyquadrat on Jan 23 2018, 7:05 PM.

Details

Reviewers

ngraham
elvisangelaccio

Group Reviewers

Dolphin

Commits

R318:ea6a2424fb45: Add option to sort for original date

Summary

Takes the original date a photo was taken out of the data provided by Baloo & makes it available to the user

FEATURE: 303645

Test Plan

Repository

R318 Dolphin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

xyquadrat requested review of this revision.Jan 23 2018, 7:05 PM

xyquadrat created this revision.

xyquadrat edited the test plan for this revision. (Show Details)

ngraham added inline comments.

src/kitemviews/kfileitemmodel.cpp
2315	"Original Date" is rather ambiguous. Maybe... "Date Photographed"?

Change name from "Original Date" to "Date Photographed"

This should make it clearer what exactly this property is.

xyquadrat marked an inline comment as done.Jan 23 2018, 7:16 PM

Looks great. Any chance you can attach a screenshot to the Summary section, too?

This revision is now accepted and ready to land.Jan 23 2018, 7:40 PM

xyquadrat edited the summary of this revision. (Show Details)

In D10059#195152, @ngraham wrote:

Looks great. Any chance you can attach a screenshot to the Summary section, too?

Sure, is the one I attached right now enough?

Perfect! I'll land this on the master branch (since it adds a new string) later today. Thanks for the patch! You're doing great work.

Please use FEATURE: rather than BUG: in the commit message.

In D10059#195173, @elvisangelaccio wrote:

Please use FEATURE: rather than BUG: in the commit message.

Updated the commit message to use FEATURE now.

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/kitemviews/kfileitemlistwidget.cpp (2 lines)
M			src/kitemviews/kfileitemmodel.h (2 lines)
M			src/kitemviews/kfileitemmodel.cpp (1 line)
M			src/kitemviews/private/kbaloorolesprovider.cpp (1 line)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	25841	bba44ae		Jan 23 2018, 7:05 PM	★	★
Diff 2	25842	bba44ae	Change name from "Original Date" to "Date Photographed"	Jan 23 2018, 7:16 PM	★	★
Diff 3	25853	bba44ae	R318:ea6a2424fb454eafb80a731e5fdce4e4a50cb606	Jan 23 2018, 11:33 PM	★	★