Build TerminalPanel also on Windows
ClosedPublic
Actions

Authored by elvisangelaccio on Jan 21 2018, 11:26 AM.

Details

Reviewers

None

Group Reviewers

Dolphin
Craft

Commits

R318:87e8d0ba5f80: Build TerminalPanel also on Windows

Summary

terminalpanel.cpp *should* compile on Windows, so there is no reason to
remove it from the build and use tons of #ifdefs in dolphinmainwindow.

We still keep the terminal panel disabled on Windows
(i.e. the two remaining #ifndef Q_OS_WIN in dolphinmainwindow),
because it is probably not functional.

But at least we won't break the Windows CI every time
someone touches the terminal panel code (see e.g. 2e942237c9).

Test Plan

Builds on Linux, someone on Windows should test this patch if possible.

Diff Detail

Repository

R318 Dolphin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

elvisangelaccio requested review of this revision.Jan 21 2018, 11:26 AM

elvisangelaccio created this revision.

I'll push this in a couple of days if there are no objections.

This revision was not accepted when it landed; it landed in state Needs Review.Feb 10 2018, 9:35 PM

Closed by commit R318:87e8d0ba5f80: Build TerminalPanel also on Windows (authored by elvisangelaccio). · Explain Why

This revision was automatically updated to reflect the committed changes.

Alas, this broke the Windows CI build.
Please see https://build.kde.org/job/Applications%20dolphin%20kf5-qt5%20WindowsMSVCQt5.9/69/consoleText

Crap. I'll have a look later today.

In D10006#204153, @bcooksley wrote:

Alas, this broke the Windows CI build.
Please see https://build.kde.org/job/Applications%20dolphin%20kf5-qt5%20WindowsMSVCQt5.9/69/consoleText

Fixed with e136d8cfeb1d7dced.

Thanks for the quick fix.