Thanks!
It is actually Elisa that is initializing the value with -1 (see musicaudiotrack.cpp if you are interested). The playlist (PlayListEntry.qml) already does the check, but does != -1. Could you change your patch to check for >-1 for all three files? This way we would handle the case if a track is incorrectly tagged with a track number 0.

Sure! I'll update the description too

Check for > -1 to catch tracks tagged with a track number 0
Also include PlayListEntry.qml

januz edited the summary of this revision. (Show Details)Jan 21 2018, 10:31 PM

Thanks for your work

This revision is now accepted and ready to land.Jan 22 2018, 8:01 AM

Closed by commit R255:0596c053f643: Disable track number for songs that don't have it (authored by januz). · Explain WhyJan 22 2018, 12:47 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/MediaTrackDelegate.qml (15 lines)
M			src/MediaTrackMetadataView.qml (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	25698	bdd9044		Jan 20 2018, 10:09 PM	★	★
Diff 2	25731	bdd9044	Check for > -1 to catch tracks tagged with a track number 0	Jan 21 2018, 10:29 PM	★	★
Diff 3	25754	7fbdce6	R255:0596c053f643f8d14cfd3f5ec7b7b7fe474bca34	Jan 22 2018, 12:47 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
c50615f94bf1	426e842589e8	7af80edb695c	Diego Gangl	Hide tracknumber in all tracks view	Jan 20 2018, 10:07 PM
7af80edb695c	c5cbd54e37da	c7983811f50c	Diego Gangl	Hide track number for metadata view	Jan 20 2018, 10:03 PM
c7983811f50c	94562e88a7c7	bdd9044cea74	Diego Gangl	Disable track number for songs that don't have it	Jan 20 2018, 1:06 AM

Disable track number for songs that don't have itClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 25698

src/MediaTrackDelegate.qml

src/MediaTrackMetadataView.qml

Disable track number for songs that don't have it
ClosedPublic
Actions

Revision Contents
Changeset List