DONE with https://invent.kde.org/games/kmines/-/commit/a0ff777ec444fe392f359aa863fd2ddd176427d6

Hmm, arc land says...

In D21277#675591, @aacid wrote:

Ok, i guess you can commit it.

Any special reason it's called "No. 2"? Is there a No 1 somewhere?

@aacid: I just saw that you confirmed that CC BY 3.0 would also have been fine. Anyway, now it is CC BY-SA 4.0. :-)
Can we land this now? I see no further comments.

Rework theme to fix licensing issues

I am a little late but I would like to add something. In Kate - at least for me - the by far most used action is "Focus/defocus Terminal". This function also opens the terminal if it was not open before.

Hi @jtamate, thanks for raising this legal concern. I only can read the English translation you provided. It seems only images and videos of _people_ using or promoting tobacco products are disallowed.

Looks great. Thanks, Nate. (Sidenote: I wonder if there is an obvious way to close the additional session. Currently, I use the keyboard: Ctrl+Alt+F8 and then Ctrl+Alt+Back,Back)

In D23190#514730, @mickaelbo wrote:

Set the regexp button tooltip.

@gregormi: you clearly did all the work, you deserve to be the author if it matters to you.

Thanks for taking this over. My suggestion for the tooltip:

In D18083#492582, @cullmann wrote:

Could you finalize this? I think it really would be a nice addition!

In D17138#482940, @ngraham wrote:

You probably need to delete ~/.local/share/kxmlgui5/kate*/*.rc

In D21861#484556, @dhaumann wrote:

I'd like to drop the " Current" prefix in all the variables. It just makes the names longer and I don't see any value for users. Comments?

Looks good to me.

Hi, thanks for asking. The problem is, that I have trouble with how the menu mechanism works. E.g. some time during my (non-root) development now my system/distro-installed Kate shows changes in the File menu. I don't know how to revert/reset these so I am not sure if my change actually does the right thing.

In D21277#467286, @aacid wrote:

If we're going to be so concerned about what we expain to kids, i'd rather use something else than a cigarrette to represent trash

In D21293#467150, @dhaumann wrote:

New color is red:

@gregormi If you want other colors, please propose them yourself :-)

Side note: I use the Show Desktop widget for some time now and switched it to the "Minimize all Windows" version. This seems more intuitive to me because: The current default Show Desktop introduces a new mode (where all windows fly to all sides of the screen where small bits of the windows are still visible). This mode currently forces all other windows to also come back when I click on just on window in the Task Manger to make it visible. Maybe it could be considered to use the "Minimize all Windows" by default.

Makes sense.

There are two things left that could be useful:

In D17443#441082, @dhaumann wrote:

+1 for Christophs suggestion: Just remove F6 for now, this definitely will not hurt or introduce any shortcut conflict. In addition, I also agree with the changes in the replicode plugin (remove F8 + F9).

@gregormi Can you update the patch so that we can proceed? Or shall we simply proceed in case you don't have time right now?

In T10719#180305, @apol wrote:

Do you know where we can find the source code?

In D18083#413722, @cullmann wrote:

That I don't misunderstand: the clickable thingy is the thing shown in the first screenshots inside the lineedits?

Hi Christoph, thanks for the ping.
There are two possible paths for this change in total:

1. Revert the changes which introduce the new clickable icons because they are considered visual clutter
2. Keep the clickable icons and revert the tooltip changes

In D17971#405295, @dhaumann wrote:

• I like the idea of "Show as popup" or "Display as inline note". I was misunderstanding this first, though: For "Display as inline note" I first thought of the new InlineNoteInterface, but I think you are talking about KTextEditor::Message.

Actually, I meant both, KTextEditor::Message for "Show as popup" and InlineNoteInterface for the other one. For first one, there are some use cases; the second one could be used to display git blame information more persistently than with a disappearing note. Both nice to have, of course.

In D17971#404900, @dhaumann wrote:

@gregormi

• Output "Replace Current Document": works fine. Idea: restore cursor position after operation.
  • Given the document usually changed afterwards, "restoring the cursor position" is pretty much undefined, and almost never correct...

I tried the plugin, these are my observations:

In T8484#174434, @ngraham wrote:

https://community.kde.org/Get_Involved/development.
What do people think? Does it work?

In T10317#173650, @sars wrote:

3. Ctrl+Shift+F is a semi standard full-screen shortcut in KDE. Gwenview, Ocular and Konqueror are examples of this.

In T10281#173226, @loh.tar wrote:

In T10281#172290, @loh.tar wrote:

Yes, my English is bad. But "Outline View" sound to me less fitting than my "Index View".

In T10319#173149, @dhaumann wrote:

The example of the diff of two views is out of scope: On KTextEditor level, we don't even have a concept of having multiple views side by side, that is business of the host application. You will really only have the concept of one active view.

In T10317#173006, @sars wrote:

1. These buttons are different than the other buttons in that they modify the UI of the toolview but not the search. So mixing them is maybe not the best? One could think about moving them to the right side of the other buttons and have some type of separator between...

In D18083#392525, @sars wrote:

My personal taste would be to only have a small tool-tip saying: See the "Add.." context menu entry for regular expression help.

The search plugin is already cluttered with a lot of buttons...

Thanks Kåre for the review. I'll update the change.

In T10279#173063, @loh.tar wrote:

But I'm not sure if "navigate up/down/left/right" in some list should be done by a shortcut where you jump "free" in some text like in Kate or a Web-Browser.

• Add line edit action icons which makes the tooltip obsolete

(Screenshots in the description)

In D17443#392442, @loh.tar wrote:

Um, can't find here a hint that this is try to follow some "defined standard", like CUA. https://en.wikipedia.org/wiki/IBM_Common_User_Access

"...all major Unix GUI environments/toolkits, whether or not based on the X 
Window System, have featured varying levels of CUA compatibility.." 
"The current major environments, GNOME and KDE, also feature extensive CUA 
compatibility..."

Web-search list some KDE docs for Krusader or Gwenview but so far no "master page".

Particularly I ask me why the S&R plugin should use own shortcuts when there is F3/Shift-F3 already defined (at least here and there listed as Standard) I would prefer that the default short cuts always works, independent what was the initial search tool.

But probably I once again misunderstood something :-)

@loh.tar: I redirect the general discussion to here: https://phabricator.kde.org/T10279

This is the plan :) https://phabricator.kde.org/T10279

• Adapt kwriteui.rc

What I wonder: during the work with the .rc menu files I noticed that even the menu in Kate which is installed in root got affected by the changes I made in the development version and I had to regularly change the version number to make changes take effect. Is this normal?

• Better naming of ids
• Move Close other, Close all and Close orphans to submenu "Save Variants" (as discussed here https://phabricator.kde.org/D17137)

This is what is looks like now (together with latest changes from https://phabricator.kde.org/D17138):

• Move "Save As..." out of the submenu

@loh.tar: I like the new status bar.

In D17443#379785, @gregormi wrote:

In D17443#379221, @dhaumann wrote:

Could you serch for Key_F6 in the KTextEditor and Kate source code? I want to avoid that we overlook something.

I'll report back.

With respect to bringing this https://phabricator.kde.org/T10279 forward, how should I proceed here? Can this go in as first step (after I removed F10 and F11)? (see also https://phabricator.kde.org/D17443)

In D17308#370361, @sars wrote:

What if you have Project, CTags and the new Zeal plugins active? You need to differentiate them somehow.
[...]
As it is right now for the project plugin, it is a bit strange to have a sub-menu for one action, but we could get more....

Can you make the RegExp tool-tip available only when we are in RegExp mode?

This is definitely worth to proceed, thanks!