Kate: Keyboard shortcuts F6/Shift+F6 for Next/Previous Match
ClosedPublic

Authored by gregormi on Dec 8 2018, 11:13 PM.

Details

Summary

For the Search and Replace plugin use these default shortcuts as in Qt Creator:

  • F6: Next Match
  • Shift+F6: Previous Match

Remove unnecessary F keys:

  • Remove default shortcuts F8 and F9 from the Replicode Plugin. F8 conflicts with a split view shortcut and F9 can stay free.
  • Maybe also remove the F8 split view shortcut to make way for a non-F key variant

Diff Detail

Repository
R40 Kate
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
gregormi created this revision.Dec 8 2018, 11:13 PM
Restricted Application added a project: Kate. · View Herald TranscriptDec 8 2018, 11:13 PM
Restricted Application added a subscriber: kwrite-devel. · View Herald Transcript
gregormi requested review of this revision.Dec 8 2018, 11:13 PM
gregormi edited the summary of this revision. (Show Details)Dec 8 2018, 11:15 PM
gregormi added a reviewer: Kate.

The changes in the replicode plugin certainly look good to me and can be committed.

Could you serch for Key_F6 in the KTextEditor and Kate source code? I want to avoid that we overlook something.

Ctrl+shift+P: ctrl+P is print. The shift shortcuts are typically the opposite, which is not the case here.

The changes in the replicode plugin certainly look good to me and can be committed.

ok

Could you serch for Key_F6 in the KTextEditor and Kate source code? I want to avoid that we overlook something.

I'll report back.

Ctrl+shift+P: ctrl+P is print. The shift shortcuts are typically the opposite, which is not the case here.

In the area of Split Views Shift seems not to be the opposite of the original shortcut (e.g. current shortcuts Ctrl+Shift+L (vertical split) and Ctrl+Shift+T (horizontal split) => without Shift it is 'Save All' and 'Transpose'). So maybe an exception from the general rule is fine here. I wondered what the opposite of Print might be and checked what Ctrl+Shift+P does in other applications, namely those two: 1. Firefox: Private Browsing, 2. Libre Office Writer: "Hochgestellt"; so also very different meanings here.
Or is there maybe a specific reason why currently an F key (F8) is used here?

Could you serch for Key_F6 in the KTextEditor and Kate source code? I want to avoid that we overlook something.

I'll report back.

Relevant occurrences of F6 in Kate source code:

Relevant occurrences of F6 in KTextEditor source code:

So, no problem there. Ready from my side.

kate/kateviewmanager.cpp
179

todo: Remove F8

sars added a subscriber: sars.Jan 13 2019, 10:51 AM

I would be OK with the addition of F6 and Shift+F6 to the Search plugin, but I think it would be good to have a plan for all the shortcuts and update all at once....

Um, can't find here a hint that this is try to follow some "defined standard", like CUA. https://en.wikipedia.org/wiki/IBM_Common_User_Access

"...all major Unix GUI environments/toolkits, whether or not based on the X 
Window System, have featured varying levels of CUA compatibility.." 
"The current major environments, GNOME and KDE, also feature extensive CUA 
compatibility..."

Web-search list some KDE docs for Krusader or Gwenview but so far no "master page".

Particularly I ask me why the S&R plugin should use own shortcuts when there is F3/Shift-F3 already defined (at least here and there listed as Standard) I would prefer that the default short cuts always works, independent what was the initial search tool.

But probably I once again misunderstood something :-)

@loh.tar: I redirect the general discussion to here: https://phabricator.kde.org/T10279

Could we do this minimal invasive?
Just remove F6 for show iconborder and use there the ac->setDefaultShortcut(a, QKeySequence(Qt::CTRL + Qt::Key_E, Qt::CTRL + Qt::Key_B));
But avoid any other shortcut juggling?

+1 for Christophs suggestion: Just remove F6 for now, this definitely will not hurt or introduce any shortcut conflict. In addition, I also agree with the changes in the replicode plugin (remove F8 + F9).

@gregormi Can you update the patch so that we can proceed? Or shall we simply proceed in case you don't have time right now?

gregormi edited the summary of this revision. (Show Details)Apr 1 2019, 4:46 PM

+1 for Christophs suggestion: Just remove F6 for now, this definitely will not hurt or introduce any shortcut conflict. In addition, I also agree with the changes in the replicode plugin (remove F8 + F9).

@gregormi Can you update the patch so that we can proceed? Or shall we simply proceed in case you don't have time right now?

@dhaumann: thanks for the offer, I am glad if you proceed with the change.

cullmann accepted this revision.Apr 22 2019, 4:41 PM

We go with the minimal needed changes.

This revision is now accepted and ready to land.Apr 22 2019, 4:41 PM
This revision was automatically updated to reflect the committed changes.