Fri, Jul 13
Well I actually didn't see the line above at first. Thanks for the correction
Thu, Jul 12
Oh dear, you're right. Should've looked at the whole picture...
Also note the big elephant in the room: the typo is not in the British English translation, but in the original text...
I just pushed 812910752712f185e5ef19bf4786346217232475 to fix it, which will invalidate all the translations (so Steve will notice it by tomorrow).
I've forwarded the information to the translator...
@pino Thanks for the hint - I wasn't aware that the translations in git are a one-way street...
Note that translations are handled by an automatic system (informally called "scripty") that extracts messages from all the translatable resources, like messages in the applications/libraries, and also strings in .desktop (and alike), and .appdata.xml files.
As such, editing translations directly is not a good idea, and indeed scripty reverted to the string actually in the en_GB translation the day after this commit.
Please contact the British English team, or the translator directly:
Sure thing - ship it!
Can you approve the revision so I can close it ?
Wed, Jul 11
Merged to master
Jun 15 2018
I've merged this to master...
Jun 14 2018
Confirmed that this builds with Qt 5.11.
Jun 7 2018
Jun 6 2018
Sure, no worries.
Jun 5 2018
(Due to the fact that we can't see user email addresses here, I could not add you as the author, but wrote it in the commit message. I hope you don't mind …)
You're right, obviously ;-) I've pushed the patch to master. Thanks :-)
May 20 2018
This is now tracked in branch elide_unnecessary_metadata
May 7 2018
May 6 2018
Mar 26 2018
Pushed it finally. Thanks again :-)
So … I just tried to manually commit your patch (I'm pretty sure this can somehow be done automagically through that Phabricator/Arcanist/Whatever widget, but who knows?! ;-) – but I need your (full?) name and an email address, so that I can set the correct author for the commit. I found neither … would you be so kind to tell me (e. g. via IRC at the kphotoalbum channel on freenode? I'm most of the time logged in as l3u there). Thanks :-)
Mar 18 2018
Builds and runs fine here on Gentoo, using GCC 6.4.0.
The patch seems to be reasonable to me, but I have to ask a dumb question as I'm new to that Phabricator thing: How can I test it? It doesn't live in git, does it? Can I download a patch that I can apply to a local testing branch?
Mar 16 2018
Feb 11 2018
Jan 27 2018
KPhotoAlbum should be compatible with both C++11 and C++14. Your change works with both, so: ship it!
Looks fine. Ship it!
Jan 14 2018
Jan 1 2018
No surprises during review -> accepted.
Patch verified and merged.
Dec 22 2017
More tricky than I had thought → apply to next release (I don't want to introduce bugs)