Create Task
Maniphest T12933

Improvements to index.xml file format
Closed, ResolvedPublic
Actions

Description

This task summarizes proposed changes to the index.xml file format.

Untagged category -> implemented

This is currently part of kphotoalbumrc and it is quite easy to mess it up by opening a different database and forgetting about the untagged tag. The untagged category tag is clearly a part of the database.

Proposed syntax

<Category name="someName" ...>
 <value value="untaggedTag" meta="mark-untagged"/>
</Category>

Related bug report: https://bugs.kde.org/show_bug.cgi?id=461206

Privacy settings

Currently in kphotoalbumrc.

Proposed syntax

Further discussion needed. Current implementation is based on a serialized (and simplified) ImageSearchInfo.

Related Objects
Search...

johanneszarl triaged this task as Low priority.Sep 5 2022, 9:58 PM

Setting this to low because I want to be further in the refactoring before tackling this.

johanneszarl updated the task description. (Show Details)Nov 1 2022, 10:29 PM
tleupold added a subscriber: tleupold.Nov 2 2022, 8:38 AM

About the "Privacy settings": I would simply remove this. No "real" privacy as the photos are readable anyway, unresolved issues … I'm not sure if this is a feature we really need. If somebody has photos that shouln't show up in a search, I'd create another database rather than trying to hide them through some setting.

About the untagged images tag cf. my comment to Bug #461206 on how I would implement it ;-)

johanneszarl added a comment.Nov 4 2022, 1:41 PM

I do use the privacy settings, though: there are photographs that I simply don't want to accidentally show to my in-laws, for example.
To maximize the usefulness of the feature though, I would try to make it more accessible to the average user. E.g. tie it to a specific tag or so. Currently, there's no way to really inspect the feature - you lock a set of photos away but afterwards you need to remember the criteria. Changing the set of "locked" photos (or rather the search expression) is not supported - you have to unlock, then select the new set, and lock again.

johanneszarl updated the task description. (Show Details)Nov 24 2022, 9:49 PM
johanneszarl closed this task as Resolved.Nov 24 2022, 11:59 PM
johanneszarl moved this task from Backlog to v5.9.2 on the KPhotoAlbum board.
johanneszarl claimed this task.

The untagged category/untagged tag part is implemented now.

Maybe the privacy setting should be left as-is for now. Improving the UI for it won't necessarily need any changes to the implementation, and I'm not even sure if this is better done as a setting or a database property.
I'm closing this task for now.