| ngraham |
| Spectacle |
New openScreenshotsFolder logic is to highlight recently saved file, then default save location
(save mode) or last saved file's folder (save as mode) with failsafe as default save location.
SpectacleConfig now stores the last saved files and can determine the last saved file location from the
file name through separate method. Removed extraneous methods and variables from ExportManager.
ExportManager now uses SpectacleConfig to access save location preferences.
BUG: 394182
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
Thanks for the patch! I will review it probably tomorrow. In the meantime, could you change the title to match the commit message guidelines outlined at https://community.kde.org/Infrastructure/Phabricator#Formatting_your_patch? This means phrasing it in the imperative mood ("Clarify logic for...") and keeping it short and sweet. Ideally under 80 characters.
Also, BUG 394182 needs to be BUG: 394182
Finally if you add FIXED-IN: 18.12.0 on its own line (typically under the BUG: line), it will automatically populate the appropriate field in the Bugzilla ticket when it lands.
Thanks again!
I've verified that this fixes the bug, good job! No regressions detected with save or screenshot folder locations, with an existing install or when using a fresh config.
Please address the formatting changes I requested in the previous comment, and then this can land!
Can you re-base this on master? It no longer cleanly merges when I go to land it. A git pull --rebase origin master should do it, and then afterwards you'll need to re-compile and run so you can verify that the merge was successful.
That worked, thanks! I've landed this for you.
Any update on D15059? I feel like we're pretty close to the finish line for that one! It will also need a rebase on master since I re-did the layout of the settings window recently.