Removed check box for 'copy file location after saving' from General options page and added back to Save options page. Also renamed group box to 'Save Location' and renamed label for default save location to 'Default Save Location' to make the group box title more applicable to the 'copy file location after saving' setting.
BUG: 390793
FIXED-IN: 18.12.0
Before:
After:
| Lint Skipped |
| Unit Tests Skipped |
Thanks for the patch! Sorry I missed it. This is a good change overall, but I've got some comments for you to address before we can land it.
| src/Gui/SettingsDialog/SaveOptionsPage.cpp | ||
|---|---|---|
| 40 | I see why you changed this string and the one below, but would you mind reverting them for now? They will have to be changed again once I port this layout to use QFormLayout, so I'd rather not make extra work for the translators. | |
| src/Gui/SettingsDialog/SaveOptionsPage.h | ||
| 47 | Instead of adding a second one, can we simply adjust the existing markDirty function to not take any arguments (they're ignored anyway) and just re-use it? In my testing, this seems to work fine. | |
| 55 | Please match the indentation of the other items. | |
I believe I made the updates from the review. Is uploading a new diff that includes the original and review changes the preferred next step here? Thank you. This is my first go around with this.
Thanks, I will review again soon (along with your other patch). I'm going to be very busy over the next few days, so expect a slower-than-usual response time, but I'll do my best!
Thanks for your patience. This works well!
JFYI, "18.11.70" is just code for "the 18.12 beta". Only our loyal and devoted beta testers will ever see that string, so this will actually land in 18.12.0 for most users.