thomassc (Thomas Schöps)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Dec 31 2018, 1:47 PM (33 w, 2 d)
Availability
Available

Recent Activity

Tue, Jul 30

thomassc committed R32:626954a45ab0: Contextbrowser: Remove 'separated by only whitespace' possibility for showing… (authored by thomassc).
Contextbrowser: Remove 'separated by only whitespace' possibility for showing…
Tue, Jul 30, 12:04 PM

Jul 21 2019

thomassc committed R32:c1e8604d7bf2: Contextbrowser: Minor improvement to tooltip showing behavior (authored by thomassc).
Contextbrowser: Minor improvement to tooltip showing behavior
Jul 21 2019, 6:07 PM
thomassc committed R32:78d2319c14ab: CMake plugin: Do not show KMessageBox if no active window exists to not block… (authored by thomassc).
CMake plugin: Do not show KMessageBox if no active window exists to not block…
Jul 21 2019, 9:29 AM
thomassc committed R32:271257152f8f: CMake plugin: Also show an error message if the CMake configuration becomes… (authored by thomassc).
CMake plugin: Also show an error message if the CMake configuration becomes…
Jul 21 2019, 9:29 AM
thomassc committed R32:1ee9f8d5e958: CMake plugin: Show a message box if configuration fails (authored by thomassc).
CMake plugin: Show a message box if configuration fails
Jul 21 2019, 9:29 AM

Jul 8 2019

thomassc committed R39:c0321472330b: Add setting to enable/disable text drag-and-drop (on by default) (authored by thomassc).
Add setting to enable/disable text drag-and-drop (on by default)
Jul 8 2019, 5:19 PM
thomassc closed D22315: Add setting to enable/disable text drag-and-drop (on by default).
Jul 8 2019, 5:19 PM · Frameworks, Kate
thomassc added a comment to D22315: Add setting to enable/disable text drag-and-drop (on by default).

Thanks for having a look. Here is a screenshot of the config page with the new option on it (third from the bottom):

Jul 8 2019, 4:46 PM · Frameworks, Kate

Jul 7 2019

thomassc added a reviewer for D22315: Add setting to enable/disable text drag-and-drop (on by default): KTextEditor.
Jul 7 2019, 10:06 PM · Frameworks, Kate
thomassc requested review of D22315: Add setting to enable/disable text drag-and-drop (on by default).
Jul 7 2019, 10:05 PM · Frameworks, Kate
thomassc added a comment to D22309: Snippets: Fix the keyboard shortcuts for new snippets not working.

Thanks for reviewing. No idea whether there is a good reason for the action not being created during the rowInserted handling; if not, that seems like the cleaner solution indeed.

Jul 7 2019, 4:47 PM · Kate
thomassc committed R40:cd91625e8284: Snippets: Fix the keyboard shortcuts for new snippets not working (authored by thomassc).
Snippets: Fix the keyboard shortcuts for new snippets not working
Jul 7 2019, 4:34 PM
thomassc closed D22309: Snippets: Fix the keyboard shortcuts for new snippets not working.
Jul 7 2019, 4:34 PM · Kate
thomassc committed R40:f8c1d8fef15f: Snippets: Make snippet shortcuts work also if the snippets tool view is… (authored by thomassc).
Snippets: Make snippet shortcuts work also if the snippets tool view is…
Jul 7 2019, 4:33 PM
thomassc closed D22308: Snippets: Make snippet shortcuts work also if the snippets tool view is minimized, by adding the QActions to the main window instead of the tool view.
Jul 7 2019, 4:33 PM · Kate
thomassc added a reviewer for D22309: Snippets: Fix the keyboard shortcuts for new snippets not working: Kate.
Jul 7 2019, 2:13 PM · Kate
thomassc requested review of D22309: Snippets: Fix the keyboard shortcuts for new snippets not working.
Jul 7 2019, 2:12 PM · Kate
thomassc added a reviewer for D22308: Snippets: Make snippet shortcuts work also if the snippets tool view is minimized, by adding the QActions to the main window instead of the tool view: Kate.
Jul 7 2019, 2:01 PM · Kate
thomassc requested review of D22308: Snippets: Make snippet shortcuts work also if the snippets tool view is minimized, by adding the QActions to the main window instead of the tool view.
Jul 7 2019, 1:59 PM · Kate

May 27 2019

thomassc committed R32:0c6bf764b634: ProblemHighlighter: Fix mark type handling (authored by thomassc).
ProblemHighlighter: Fix mark type handling
May 27 2019, 8:55 AM
thomassc committed R32:69efe7db3ed7: ProblemHighlighter: Use qobject_cast for MarkInterface as advised in its… (authored by thomassc).
ProblemHighlighter: Use qobject_cast for MarkInterface as advised in its…
May 27 2019, 8:46 AM
thomassc committed R32:dedcba67680a: Attempt to fix a crash on shutdown (authored by thomassc).
Attempt to fix a crash on shutdown
May 27 2019, 8:46 AM

May 1 2019

thomassc committed R32:4c1a518211d9: Clang Plugin: Report some problems from included files (authored by thomassc).
Clang Plugin: Report some problems from included files
May 1 2019, 12:39 PM
thomassc closed D18224: Clang Plugin: Report some problems from included files.
May 1 2019, 12:39 PM · KDevelop

Apr 15 2019

thomassc added a comment to D18224: Clang Plugin: Report some problems from included files.

Upon reopening a file, we should only update the problems of changed files that got updated. Otherwise we should only grab the TU for the main .cpp file and attach it, such that we can do code completion.

Apr 15 2019, 10:59 PM · KDevelop
thomassc updated the diff for D18224: Clang Plugin: Report some problems from included files.

Re-add m_diagnosticsCache with a hopefully correct caching implementation. Differing from the original situation, the new function createExternalProblem() adapts the problems it creates to the specific file they are inserted in. The cache thus only caches the original problems as created by ClangDiagnosticEvaluator::createProblem(). createExternalProblem() makes copies of these with a new copy constructor added to ClangProblem.

Apr 15 2019, 10:59 PM · KDevelop

Apr 14 2019

thomassc added a comment to D18224: Clang Plugin: Report some problems from included files.

I am sorry, I think that I misunderstood how the cache works. Please disregard my previous message. I am wondering where the problem that I've been seeing then comes from, seems like it has a different origin.

Apr 14 2019, 10:11 AM · KDevelop

Apr 13 2019

thomassc added a comment to D18224: Clang Plugin: Report some problems from included files.

I re-tested the behavior on files from an actual project and it showed the same behavior when editing files as described in my last post, regardless of how many files are included from the files that are edited. I noticed that the behavior is different when re-opening files: in this case, problemsForFile() is actually called for a larger set of files (although from only looking at this set of files, it seemed a bit random and it was not clear to me how it is determined, I'll have to dig into the source code for this at some point ...).

Apr 13 2019, 9:21 PM · KDevelop
thomassc committed R32:4acac3f79695: TestFile: On destruction, close associated document if open and stop the… (authored by thomassc).
TestFile: On destruction, close associated document if open and stop the…
Apr 13 2019, 7:55 PM
thomassc closed D18567: Make testActiveDocumentsGetBestPriority() clean up after itself.
Apr 13 2019, 7:55 PM · KDevelop

Apr 6 2019

thomassc updated the diff for D18567: Make testActiveDocumentsGetBestPriority() clean up after itself.

Thanks for the info. I didn't spot it at first since it is hidden in a dropdown menu.

Apr 6 2019, 2:58 PM · KDevelop
thomassc commandeered D18567: Make testActiveDocumentsGetBestPriority() clean up after itself.
Apr 6 2019, 2:56 PM · KDevelop
thomassc updated the diff for D18224: Clang Plugin: Report some problems from included files.

Address Milian's comments; remove m_diagnosticsCache.

Apr 6 2019, 2:52 PM · KDevelop
thomassc added inline comments to D18224: Clang Plugin: Report some problems from included files.
Apr 6 2019, 2:50 PM · KDevelop
thomassc added a comment to D18567: Make testActiveDocumentsGetBestPriority() clean up after itself.

Thanks for the update. Seems good to me.

Apr 6 2019, 12:16 PM · KDevelop

Mar 2 2019

thomassc added a comment to D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713.

I guess the previous situation is still more practical, since by temporarily adding a newline there below the oversized line, it is at least possible to edit that line. With the line cut off, it is impossible to edit. Also, in cases where a line is only slightly oversized (as with the emoji example), with the overpainting it might look just fine, whereas with the cutoff it won't look fine.

Mar 2 2019, 3:11 PM · Frameworks, Kate

Mar 1 2019

thomassc added a comment to D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713.

If you keep the overpainting, you will just overpaint the next line partially with it, that won't help that much, IMHO.

Take a look at bug 404713.

Mar 1 2019, 12:03 PM · Frameworks, Kate

Feb 28 2019

thomassc added a comment to D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713.

The summary of this diff reads a bit as if it doesn't noticeably improve behaviour

Feb 28 2019, 9:11 PM · Frameworks, Kate
thomassc added a comment to D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713.

We trade one bug for another. Which one is worse?

Feb 28 2019, 8:57 PM · Frameworks, Kate

Feb 25 2019

thomassc added a comment to D18229: Contextbrowser: Ability to show combined problems and decl tooltip.

Personally, I don't think that I share the concerns about large tooltips. Even in your screenshot it looks fine to me. Since as written before, it can be very easily hidden if desired (e.g. just by clicking in the editor text area). I'd much rather have as much relevant information at once instead of having to click another "expand" button each time to see more. But that's just my personal opinion. Maybe others can comment too.

Feb 25 2019, 12:17 PM · KDevelop

Feb 24 2019

thomassc updated the diff for D18224: Clang Plugin: Report some problems from included files.

Address comments. Now, problems are created for each "requested here" child diagnostic that refers to the current document. This may be more than just the last child diagnostic, since there may be multiple ones referring to the current document.

Feb 24 2019, 7:35 PM · KDevelop
thomassc added a comment to D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713.

I think that this change will fix bug 403470 as well.

Feb 24 2019, 5:41 PM · Frameworks, Kate

Feb 23 2019

thomassc updated the diff for D18567: Make testActiveDocumentsGetBestPriority() clean up after itself.

Thanks for pointing me to the right places.

Feb 23 2019, 8:53 PM · KDevelop
thomassc added a comment to D18229: Contextbrowser: Ability to show combined problems and decl tooltip.

Interesting, I didn't know about the mode which highlights problematic lines. Thanks a lot for pointing it out. I had to look for it, and it turned out that this setting is at: Settings dialog -> Language Support -> Semantic Code Highlighting block -> Highlight problematic lines. I can't remember deactivating this, so it's probably off by default? It seems potentially very useful though, given that the underlines are sometimes easy to overlook, and the red line highlighting also shows up in the scrollbar minimap as you write. When this setting is active, the region where the problem tooltip shows up indeed makes more sense to me. It still doesn't match up though, for example if there are some whitespace lines before the line with the error, then the tooltip will also show when hovering somewhere over these whitespace lines.

Feb 23 2019, 5:37 PM · KDevelop
thomassc committed R230:1f8a8492eae3: Add myself (thomassc) to relicensecheck.pl (authored by thomassc).
Add myself (thomassc) to relicensecheck.pl
Feb 23 2019, 3:55 PM
thomassc added a comment to D18229: Contextbrowser: Ability to show combined problems and decl tooltip.

There can be scrollbars in problem reports, see the attached screenshot:

Feb 23 2019, 3:36 PM · KDevelop

Feb 14 2019

thomassc added a comment to D18229: Contextbrowser: Ability to show combined problems and decl tooltip.

Regarding keyboard navigation, it does not work for combined tooltips unfortunately. However, I wasn't aware of the existence of that feature at all before you asked about it ...

Feb 14 2019, 1:00 AM · KDevelop
thomassc updated the diff for D18567: Make testActiveDocumentsGetBestPriority() clean up after itself.

Regarding waiting for the background parser on TestFile destruction, I didn't find a way to query whether a parse job is running or to wait for it, if it was started externally, using existing code (but I'm also not familiar with the codebase). As an alternative, one can do Q_ASSERT(ICore::self()->languageController()->backgroundParser()->isIdle()); in the test cleanup function to ensure that the tests don't leave the background parser running. This might also be a good idea to ensure that the tests don't influence each other in that way.

Feb 14 2019, 12:55 AM · KDevelop

Jan 27 2019

thomassc added a comment to D18224: Clang Plugin: Report some problems from included files.

This new patch (hopefully) addresses the test flakiness that I observed before:
https://phabricator.kde.org/D18567

Jan 27 2019, 7:20 PM · KDevelop
thomassc added a reviewer for D18567: Make testActiveDocumentsGetBestPriority() clean up after itself: KDevelop.
Jan 27 2019, 7:16 PM · KDevelop
thomassc requested review of D18567: Make testActiveDocumentsGetBestPriority() clean up after itself.
Jan 27 2019, 7:15 PM · KDevelop

Jan 20 2019

thomassc added a comment to D18224: Clang Plugin: Report some problems from included files.

I moved the code into helper functions and added an initial version of the tests. The tests for having the function and the call in the same file, and for having a chain of template functions in the same file include QEXPECT_FAIL(). In principle it would be easy to generate additional problems for these cases, but then a single actual problem would be represented by multiple problems in the same file. Maybe it would be cleaner to make a single problem have multiple ranges.

Jan 20 2019, 9:07 PM · KDevelop
thomassc updated the diff for D18224: Clang Plugin: Report some problems from included files.

Make helper functions and add tests, as requested by Milian.

Jan 20 2019, 7:30 PM · KDevelop
thomassc added a comment to D18218: Properly display argument names of template functions.

I just noticed this old bug: https://bugs.kde.org/show_bug.cgi?id=368460
Should the template parameters be put into a separate context?

Jan 20 2019, 6:07 PM · KDevelop
thomassc added a comment to D18218: Properly display argument names of template functions.

Yes, the behavior of this patch is as described by Milian.

Jan 20 2019, 3:30 PM · KDevelop
thomassc added a comment to D18229: Contextbrowser: Ability to show combined problems and decl tooltip.

This is how it looks on my system:

Jan 20 2019, 2:45 PM · KDevelop
thomassc updated the diff for D18229: Contextbrowser: Ability to show combined problems and decl tooltip.

Cosmetic improvement to combined problems and decl tooltip

Jan 20 2019, 2:43 PM · KDevelop

Jan 13 2019

thomassc updated the summary of D18229: Contextbrowser: Ability to show combined problems and decl tooltip.
Jan 13 2019, 6:00 PM · KDevelop
thomassc added a reviewer for D18229: Contextbrowser: Ability to show combined problems and decl tooltip: KDevelop.
Jan 13 2019, 5:58 PM · KDevelop
thomassc requested review of D18229: Contextbrowser: Ability to show combined problems and decl tooltip.
Jan 13 2019, 5:57 PM · KDevelop
thomassc updated the summary of D18218: Properly display argument names of template functions.
Jan 13 2019, 4:24 PM · KDevelop
thomassc updated the diff for D17932: Improvements to completion.

Change to a single setter for match_cs and exact_match_cs to avoid restriction on call order of functions

Jan 13 2019, 4:21 PM · Frameworks, KTextEditor, Kate
thomassc updated the diff for D17915: Clang CodeCompletion: No auto-completion for numbers.

QString --> const auto (for real)

Jan 13 2019, 4:07 PM · KDevelop
thomassc added a comment to D17915: Clang CodeCompletion: No auto-completion for numbers.

I don't think that I have commit rights. Feel free to commit.

Jan 13 2019, 4:06 PM · KDevelop
thomassc updated the diff for D17915: Clang CodeCompletion: No auto-completion for numbers.

QString --> const auto

Jan 13 2019, 4:05 PM · KDevelop
thomassc added a reviewer for D18224: Clang Plugin: Report some problems from included files: KDevelop.
Jan 13 2019, 2:11 PM · KDevelop
thomassc requested review of D18224: Clang Plugin: Report some problems from included files.
Jan 13 2019, 2:08 PM · KDevelop

Jan 12 2019

thomassc added a reviewer for D18218: Properly display argument names of template functions: KDevelop.
Jan 12 2019, 9:49 PM · KDevelop
thomassc requested review of D18218: Properly display argument names of template functions.
Jan 12 2019, 9:48 PM · KDevelop
thomassc updated the diff for D17932: Improvements to completion.

Update according to Milian's comments

Jan 12 2019, 6:05 PM · Frameworks, KTextEditor, Kate
thomassc added a comment to D17932: Improvements to completion.

Thanks for reviewing. Regarding the question about which models would have an insensitive exact match, and which ones have sensitive exact matches:

Jan 12 2019, 6:04 PM · Frameworks, KTextEditor, Kate
thomassc updated the diff for D17915: Clang CodeCompletion: No auto-completion for numbers.

Update according to Milian's comment

Jan 12 2019, 4:04 PM · KDevelop
thomassc added a comment to D17915: Clang CodeCompletion: No auto-completion for numbers.

You are right, this should be changed. I was under the wrong impression that the original diff worked since it still showed the completion when typing something like "foo1" from the beginning. But actually, if "foo" is already there before and one starts typing at "1", then it failed.

Jan 12 2019, 4:04 PM · KDevelop

Jan 9 2019

thomassc added a comment to D17909: Clang plugin: Handle CUDA files better.

Name: Thomas Schöps, Email: tom dot schoeps aet gmail dot com
Thanks for committing this. I'll try using arcanist next time.

Jan 9 2019, 11:31 PM · KDevelop
thomassc added a comment to D17909: Clang plugin: Handle CUDA files better.

I don't think that I have commit rights.

Jan 9 2019, 12:45 PM · KDevelop

Jan 3 2019

thomassc added a comment to D17885: QuickOpen: Trim whitespace from input.

Thanks for the feedback. I don't think I have commit rights, feel free to commit it for me.

Jan 3 2019, 8:05 PM · KDevelop

Jan 2 2019

thomassc added inline comments to D17909: Clang plugin: Handle CUDA files better.
Jan 2 2019, 11:00 PM · KDevelop
thomassc requested review of D17932: Improvements to completion.
Jan 2 2019, 10:42 PM · Frameworks, KTextEditor, Kate
thomassc added a comment to D17915: Clang CodeCompletion: No auto-completion for numbers.

As far as I can tell, the changed function is indeed responsible to determine whether to do *automatic* invocation of KDevelop's completion. Manual invocation by the user is still possible by pressing Ctrl+Space. The automatic word completion by KTextEditor, on the other hand, still works for numbers after this change. But it is far less intrusive since it only shows up after typing a few digits and if there are matching other numbers in the same file. So the probability that it offers useful completions is likely much higher, and I'd personally leave that one as it is.

Jan 2 2019, 1:53 PM · KDevelop
thomassc requested review of D17915: Clang CodeCompletion: No auto-completion for numbers.
Jan 2 2019, 12:27 PM · KDevelop
thomassc updated the diff for D17904: Highlight CUDA .cu and .cuh files as C++.

Thanks for having a look. I assume that the "version" attribute needs to be increased and the "kateversion" does not. I updated the diff accordingly. I don't think that I have any commit rights, can you commit?

Jan 2 2019, 11:16 AM · Frameworks, Framework: Syntax Highlighting, Kate

Jan 1 2019

thomassc requested review of D17909: Clang plugin: Handle CUDA files better.
Jan 1 2019, 11:26 PM · KDevelop
thomassc requested review of D17904: Highlight CUDA .cu and .cuh files as C++.
Jan 1 2019, 9:38 PM · Frameworks, Framework: Syntax Highlighting, Kate

Dec 31 2018

thomassc requested review of D17892: GrepView: Extend default file extensions to search.
Dec 31 2018, 8:18 PM · KDevelop
thomassc requested review of D17885: QuickOpen: Trim whitespace from input.
Dec 31 2018, 2:00 PM · KDevelop