Differential D17885

QuickOpen: Trim whitespace from input
ClosedPublic
Actions

Authored by thomassc on Dec 31 2018, 2:00 PM.

Details

Reviewers
dhaumann
Group Reviewers
KDevelop
Commits
R32:263a57379ef6: QuickOpen: Trim whitespace from input
Summary

Trim whitespace from the input to QuickOpen. For example, when copying a file path into the QuickOpen widget from some command line output and it happens to contain some whitespace at the start or end, it will still work with this patch. Without the patch, one has to remove the whitespace manually.

Test Plan

Shortly tested it manually.

Diff Detail

Repository
R32 KDevelop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
thomassc created this revision.Dec 31 2018, 2:00 PM
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptDec 31 2018, 2:00 PM
thomassc requested review of this revision.Dec 31 2018, 2:00 PM
apol added a subscriber: apol.Jan 2 2019, 5:48 PM

+1 makes sense to me.

dhaumann accepted this revision.Jan 3 2019, 12:19 PM
dhaumann added a subscriber: dhaumann.

Another +1. @thomassc Do you have commit rights or you need someone else to commit?

This revision is now accepted and ready to land.Jan 3 2019, 12:19 PM
thomassc added a comment.Jan 3 2019, 8:05 PM

Thanks for the feedback. I don't think I have commit rights, feel free to commit it for me.

Closed by commit R32:263a57379ef6: QuickOpen: Trim whitespace from input (authored by arrowd). · Explain WhyJan 4 2019, 10:44 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 48660

View Options

plugins/quickopen/quickopenwidget.cpp

Loading...