Snippets: Make snippet shortcuts work also if the snippets tool view is minimized, by adding the QActions to the main window instead of the tool view
ClosedPublic

Authored by thomassc on Jul 7 2019, 1:59 PM.

Details

Summary

The keyboard shortcut for snippets did not work while the snippets tool view was minimized. This seems to be because the snippet QActions must be added to a visible(?) widget to be considered. Thus, this change makes the snippets plugin add its actions to the main window instead of its tool view such that they remain active when the snippets tool view is minimized to the side.

Test Plan

I tested it manually. Note for testing: There seems to be another bug that sometimes prevents the shortcuts for new snippets from working (a restart of the application should make them work). I think that this is unrelated to this change and will try to address it next.

Diff Detail

Repository
R40 Kate
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
thomassc created this revision.Jul 7 2019, 1:59 PM
Restricted Application added a project: Kate. · View Herald TranscriptJul 7 2019, 1:59 PM
Restricted Application added a subscriber: kwrite-devel. · View Herald Transcript
thomassc requested review of this revision.Jul 7 2019, 1:59 PM
cullmann accepted this revision.Jul 7 2019, 2:16 PM
cullmann added a subscriber: cullmann.

Seems reasonable.

This revision is now accepted and ready to land.Jul 7 2019, 2:16 PM
This revision was automatically updated to reflect the committed changes.