Feed Advanced Search

Yesterday

tcanabrava added a reviewer for D21301: Add a TerminalHeader when using splits: ngraham.
Mon, May 20, 3:19 PM · Konsole
tcanabrava updated the diff for D21301: Add a TerminalHeader when using splits.
  • Add HeaderBar to TerminalDisplay
Mon, May 20, 3:18 PM · Konsole
tcanabrava added a reviewer for D21309: Use only one accelerator to Maximize / Unmaximize a split view: Konsole.
Mon, May 20, 3:03 PM · Konsole
tcanabrava added a reviewer for D21309: Use only one accelerator to Maximize / Unmaximize a split view: hindenburg.
Mon, May 20, 3:03 PM · Konsole
tcanabrava added reviewers for D21308: Fix the logic for Maximize / Minimize: ngraham, hindenburg, Konsole.
Mon, May 20, 3:02 PM · Konsole
tcanabrava requested review of D21309: Use only one accelerator to Maximize / Unmaximize a split view.
Mon, May 20, 2:37 PM · Konsole
tcanabrava requested review of D21308: Fix the logic for Maximize / Minimize.
Mon, May 20, 2:37 PM · Konsole
tcanabrava added reviewers for D21301: Add a TerminalHeader when using splits: Konsole, hindenburg.
Mon, May 20, 9:34 AM · Konsole
tcanabrava requested review of D21301: Add a TerminalHeader when using splits.
Mon, May 20, 9:32 AM · Konsole

Fri, May 17

tcanabrava requested review of D21263: Don't call << in a temporary vector.
Fri, May 17, 7:42 PM · KWin
tcanabrava requested review of D21262: Fix memory leak.
Fri, May 17, 7:37 PM · KWin

Thu, May 16

tcanabrava committed R319:d79c1b908fa6: Remove function, Make other function work. (authored by tcanabrava).
Remove function, Make other function work.
Thu, May 16, 9:52 AM
tcanabrava committed R319:9ba9727a00fc: Merge me later (authored by tcanabrava).
Merge me later
Thu, May 16, 9:52 AM

Wed, May 15

tcanabrava committed R319:e51642e2eb97: Headerbar ~Working~ (authored by tcanabrava).
Headerbar ~Working~
Wed, May 15, 12:51 PM
tcanabrava committed R319:89c218f32e01: New Class: TerminalWidget (authored by tcanabrava).
New Class: TerminalWidget
Wed, May 15, 12:51 PM
tcanabrava committed R319:09469b62bd88: New Class: TerminalHeaderBar (authored by tcanabrava).
New Class: TerminalHeaderBar
Wed, May 15, 12:51 PM

Tue, May 14

tcanabrava added a comment to D21216: Fix sessions not correcly loading untill a tab is focused.

I'll wait kurt's comments as I'm sure this is a hack and not a proper fix.

Tue, May 14, 2:49 PM · Konsole
tcanabrava added reviewers for D21216: Fix sessions not correcly loading untill a tab is focused: ngraham, Konsole, hindenburg.
Tue, May 14, 2:12 PM · Konsole
tcanabrava requested review of D21216: Fix sessions not correcly loading untill a tab is focused.
Tue, May 14, 2:11 PM · Konsole

Sat, May 11

tcanabrava updated subscribers of D21123: Compile without Q_FOREACH.

I’ll look the warnings, none of them appear on Gcc. Should be a clazy
warning

Sat, May 11, 2:53 PM · Konsole

Fri, May 10

tcanabrava added reviewers for D21124: Allow configuration of the Splitter Size: Konsole, ngraham, hindenburg.
Fri, May 10, 12:46 PM · Konsole
tcanabrava requested review of D21124: Allow configuration of the Splitter Size.
Fri, May 10, 12:45 PM · Konsole
tcanabrava added reviewers for D21123: Compile without Q_FOREACH: Konsole, hindenburg, sandsmark.
Fri, May 10, 12:26 PM · Konsole
tcanabrava requested review of D21123: Compile without Q_FOREACH.
Fri, May 10, 12:25 PM · Konsole
tcanabrava added reviewers for D21118: Toggle all actions when a session restore happens: ngraham, hindenburg, Konsole.
Fri, May 10, 10:23 AM · Konsole
tcanabrava requested review of D21118: Toggle all actions when a session restore happens.
Fri, May 10, 10:22 AM · Konsole

Wed, May 8

tcanabrava accepted D21046: Fix hsv effect when applied to image.
Wed, May 8, 9:06 AM
tcanabrava updated subscribers of D21055: Highlight lines coming into view when scrolling.

@ngraham as this needs input from the VDG
I personally love the idea, I would change the half of the page dimm effect by a thin line on the side (like kdevelop shows for edited lines)

Wed, May 8, 9:06 AM · Konsole

Tue, May 7

tcanabrava added a comment to D17267: Don't duplicate the tabs when Spliting the View.

Seriously much. As the splits in master are in no way near what they where
before. But you might consider trying master, you might like the current
split behavior.
(It actually splits).
For the old behavior there was just 2 complaints, your and someone that
talked to me on email, and I’ll ask you the same thing I asked him. Try to
help with patches to have the old behavior back as a mirror tabs feature.
I’m trying to solve as many bugs as I can, but I can’t do that alone :)

Tue, May 7, 7:20 PM · Konsole

Mon, May 6

tcanabrava accepted D20535: Create Machine Information Object.
Mon, May 6, 2:51 PM · Atelier: AtCore
tcanabrava added a comment to D21046: Fix hsv effect when applied to image.

can you put a screenshoot of the before / after ? I can't really read math.

Mon, May 6, 2:38 PM
tcanabrava added a comment to D18854: Allow changing the foreground/text color of buttons.

ping?

Mon, May 6, 12:24 PM
tcanabrava resigned from D15076: Build failures with KSyntaxHighlighting 5.49.
Mon, May 6, 12:24 PM · KDE Edu
tcanabrava accepted D19482: Fix-ish scrollbar background with Qt Fusion style.
Mon, May 6, 12:23 PM · Konsole
tcanabrava resigned from D19956: ki18n: updating memory manager and removing compile warnings.
Mon, May 6, 12:23 PM · Frameworks
tcanabrava added inline comments to D17201: Fix for memory leak in SessionManagerFixed.
Mon, May 6, 12:23 PM · KDE Edu
tcanabrava accepted D20334: Speed up invert colors effect.

ping?

Mon, May 6, 12:21 PM
tcanabrava resigned from D19808: elisa: code edent.
Mon, May 6, 12:21 PM
tcanabrava accepted D20335: Remove warning static member accessed through instance.
Mon, May 6, 12:21 PM
tcanabrava accepted D20398: Remove warning: do not use 'else' after 'return'.
Mon, May 6, 12:21 PM
tcanabrava added a comment to D20795: Remove warning - modernize: pass an argument by values and use std::move().

@pino ping?

Mon, May 6, 12:19 PM

Tue, Apr 30

tcanabrava committed R319:71417ac55e85: Return early if no Splitter (authored by tcanabrava).
Return early if no Splitter
Tue, Apr 30, 8:46 AM

Fri, Apr 26

tcanabrava requested changes to D20518: Enable multi-tab-only shortcuts after restoring a multi-tab session from session management.

The proces of creation / destructiion / management of the views is a bit more complex. I'll gladly accept a patch but one that actually helps to clean the current behavior. This one just hides complexity.

Fri, Apr 26, 11:40 AM · Konsole
tcanabrava accepted D20794: Simplify function return by removing the redundant empty object.
Fri, Apr 26, 11:36 AM
tcanabrava accepted D20836: Fix New tab behavior.
Fri, Apr 26, 11:35 AM · Konsole
tcanabrava added a comment to D20836: Fix New tab behavior.

O don’t really get it. Why this code needs to go to MainWindow and not to
TabbedContainer ?
Seems to me that the class that should have knowledge on how to create the
tabs is not mainwindow.

Fri, Apr 26, 9:07 AM · Konsole

Tue, Apr 23

tcanabrava committed R231:10db899f14ee: Add override to clean up warnings (authored by laysrodrigues).
Add override to clean up warnings
Tue, Apr 23, 11:20 AM
tcanabrava committed R231:2227f9a1cb9f: Add override to clean up warnings (authored by laysrodrigues).
Add override to clean up warnings
Tue, Apr 23, 11:20 AM
tcanabrava closed D19085: Add override to clean up warnings.
Tue, Apr 23, 11:20 AM
tcanabrava committed R649:7c0b056607a2: Turning on the rotation on 3D plot (authored by karinapassos).
Turning on the rotation on 3D plot
Tue, Apr 23, 11:17 AM
tcanabrava closed D19627: Turning on the rotation on 3D plot .
Tue, Apr 23, 11:17 AM
tcanabrava committed R323:1af7c48a2df4: Deprecating rotation function (authored by karinapassos).
Deprecating rotation function
Tue, Apr 23, 11:14 AM
tcanabrava closed D19645: Deprecating rotation function.
Tue, Apr 23, 11:14 AM · KDE Edu

Apr 20 2019

tcanabrava added a comment to D16138: Create the default profile if it doesn't exist.

Mind you guys that the internal implementation without a profile is kinda
broken, so this patch makes sense to me.

Apr 20 2019, 7:07 AM · Konsole

Apr 17 2019

tcanabrava updated subscribers of D20395: Ctrl-Tab should work in "split-only" view as well.

None, I’m ok with it

Apr 17 2019, 2:20 PM · Konsole

Apr 12 2019

tcanabrava added a comment to D20466: Rework scrollback settings.
In D20466#448806, @mglb wrote:

After thinking about scrollback a bit more I think history file path AND scrollback size should go to global settings. Does anyone use different profiles with different history sizes, or change size just for current session?

Another way to display this would be to only show the "info box" when unlimited is selected.

+1

Did you mean -1? :P Hiding part of an UI depending on selected option is bad UX. Moving another elements around because something appears is probably even worse.
It is also against KDE HIG: https://hig.kde.org/patterns/content/settings.html#implementation (last point)

About changes:

  • Maybe putting custom path field below radio button (and indenting it) would be better? Path which appear here will probably be longer than current field width (at least I think so), and it will not be needed to align it with fixed size field
  • All radio buttons had equal vertical spacing, and the left label was aligned to the first radio button
  • Button group instead of frame
  • Maybe kmessagebox instead of label?
Apr 12 2019, 4:23 PM · Konsole
tcanabrava added a comment to D20466: Rework scrollback settings.

Ok, I'll update the code for that.

Apr 12 2019, 1:28 PM · Konsole
tcanabrava added a comment to D20466: Rework scrollback settings.

A quick test of picking the other 2 save locations ,it doesn't seem to work. The location settings are still stored in konsolerc. Aren't they suppose to be in the .profile file now?

Another way to display this would be to only show the "info box" when unlimited is selected.

Apr 12 2019, 1:24 PM · Konsole
tcanabrava added a comment to D20466: Rework scrollback settings.

Another way to display this would be to only show the "info box" when unlimited is selected.

+1

Apr 12 2019, 1:22 PM · Konsole
tcanabrava updated the diff for D20466: Rework scrollback settings.
  • Remove useless lambda
Apr 12 2019, 7:57 AM · Konsole
tcanabrava updated the diff for D20466: Rework scrollback settings.
  • Add missing label, Add tooltips
Apr 12 2019, 7:53 AM · Konsole

Apr 11 2019

tcanabrava added a comment to D20466: Rework scrollback settings.

Only because I’m forbidden to remove configuration options that exist, for
me this is one of those niche cases that shouldn’t exist.

Apr 11 2019, 8:31 PM · Konsole
tcanabrava updated subscribers of D20466: Rework scrollback settings.

I tougth about showing the paths but my first tougth was “why do the user
cares where this is being stored”?

Apr 11 2019, 5:05 PM · Konsole
tcanabrava added reviewers for D20466: Rework scrollback settings: Konsole, hindenburg.
Apr 11 2019, 12:56 PM · Konsole
tcanabrava updated the summary of D20466: Rework scrollback settings.
Apr 11 2019, 12:55 PM · Konsole
tcanabrava requested review of D20466: Rework scrollback settings.
Apr 11 2019, 12:50 PM · Konsole

Apr 10 2019

tcanabrava committed R319:e1474c3bc949: remove clang warnings: else after return (authored by tcanabrava).
remove clang warnings: else after return
Apr 10 2019, 6:27 PM
tcanabrava closed D20444: remove clang warnings: else after return.
Apr 10 2019, 6:27 PM · Konsole
tcanabrava closed D20441: Fix clang warnings about else after return.
Apr 10 2019, 6:26 PM · Konsole
tcanabrava committed R319:13781fa6c9b6: Fix clang warnings about else after return (authored by tcanabrava).
Fix clang warnings about else after return
Apr 10 2019, 6:26 PM
tcanabrava committed R319:208218dec98a: Small code simplifications (authored by tcanabrava).
Small code simplifications
Apr 10 2019, 6:26 PM
tcanabrava closed D20438: Small code simplifications.
Apr 10 2019, 6:26 PM · Konsole
tcanabrava updated subscribers of D20438: Small code simplifications.

This is more future proof as if we change the type of the function we don’t
need to change that return.

Apr 10 2019, 5:36 PM · Konsole
tcanabrava added reviewers for D20444: remove clang warnings: else after return: Konsole, hindenburg.
Apr 10 2019, 3:21 PM · Konsole
tcanabrava requested review of D20444: remove clang warnings: else after return.
Apr 10 2019, 3:21 PM · Konsole
tcanabrava added reviewers for D20441: Fix clang warnings about else after return: Konsole, hindenburg.
Apr 10 2019, 3:14 PM · Konsole
tcanabrava requested review of D20441: Fix clang warnings about else after return.
Apr 10 2019, 3:13 PM · Konsole
tcanabrava added reviewers for D20440: Fix warning "variable loses precision int to uint8": hindenburg, Konsole.
Apr 10 2019, 3:11 PM · Konsole
tcanabrava requested review of D20440: Fix warning "variable loses precision int to uint8".
Apr 10 2019, 3:10 PM · Konsole
tcanabrava requested review of D20439: Fix alignment boundary.
Apr 10 2019, 3:07 PM · Konsole
tcanabrava added reviewers for D20438: Small code simplifications: Konsole, hindenburg.
Apr 10 2019, 3:04 PM · Konsole
tcanabrava requested review of D20438: Small code simplifications.
Apr 10 2019, 3:03 PM · Konsole
tcanabrava added a comment to D14200: Simplify newSession code.

We set this variable in two or three different files and in a few different
methods. I remember that one of the first things that I tried to do for
konsole was to simplify the creation of sessions (and this broke a lot of
code and you where not happy) but it seems that we do need to make some
compromise and align that.

Apr 10 2019, 2:29 PM · Konsole
tcanabrava updated subscribers of D14200: Simplify newSession code.

I beg your pardon? (How do I test the new session? konsole is working
for me so maybe it's something I missed)

Apr 10 2019, 2:13 PM · Konsole
tcanabrava added a comment to D15570: Use new connection style.

I forgot this for quite a while, I'll update today.

Apr 10 2019, 8:30 AM · Konsole
tcanabrava added a comment to D20115: Re enable move tab left / right via keyboard shortcuts.

The one issue I have, if you open just one tab and press the move left/right I get C for 'move right' and D for 'move left" echoed on the terminal. They go away when I open another terminal and don't appear to return even if I close all but one.

ON master w/o this patch, I still get the CD echoing on all the tabs when I try the shortcuts. So maybe it is something else. Is anyone else seeing this issue?

Apr 10 2019, 8:29 AM · Konsole

Apr 9 2019

tcanabrava added a comment to D13854: Refactor Profile and ColorScheme.

I'll add a backtrace as soon as I test this again. since I'm succeeding in my konsole code cleanup I'll get this back on track.

Apr 9 2019, 8:28 PM · Konsole
tcanabrava committed R319:8029d74a970f: Implement saving sessions recursively (authored by tcanabrava).
Implement saving sessions recursively
Apr 9 2019, 4:21 PM
tcanabrava closed D20224: Implement saving sessions recursively.
Apr 9 2019, 4:21 PM · Konsole
tcanabrava closed D20410: Display the settings as List instead of Tab.
Apr 9 2019, 4:21 PM · Konsole
tcanabrava committed R319:7bda99d7bc4e: Display the settings as List instead of Tab (authored by tcanabrava).
Display the settings as List instead of Tab
Apr 9 2019, 4:21 PM
tcanabrava added a comment to D20410: Display the settings as List instead of Tab.

too many things to fix here and there. :)

Apr 9 2019, 4:19 PM · Konsole
tcanabrava added reviewers for D20410: Display the settings as List instead of Tab: Konsole, hindenburg, ngraham.
Apr 9 2019, 3:39 PM · Konsole
tcanabrava requested review of D20410: Display the settings as List instead of Tab.
Apr 9 2019, 3:38 PM · Konsole
tcanabrava added a comment to D20398: Remove warning: do not use 'else' after 'return'.

we don't have a clangformat file specified for kde projects, maybe this is
something good to add. I voted for global .editoconfigfiles but I was
outvoted. :)

Apr 9 2019, 2:48 PM
tcanabrava updated the diff for D14200: Simplify newSession code.
  • Further simplify code
Apr 9 2019, 2:41 PM · Konsole
tcanabrava added a comment to D20395: Ctrl-Tab should work in "split-only" view as well.

When we have multiple tabs / splits this is not confusing?

Apr 9 2019, 2:24 PM · Konsole
tcanabrava added a comment to D20115: Re enable move tab left / right via keyboard shortcuts.

this should fix most of the issues. I have another patch to go related to actions, but this one needs to land first.

Apr 9 2019, 2:16 PM · Konsole
tcanabrava updated the diff for D20115: Re enable move tab left / right via keyboard shortcuts.
  • Fix action identifiers
Apr 9 2019, 2:15 PM · Konsole
tcanabrava added a comment to D20224: Implement saving sessions recursively.

@ngraham can you accept even with the shortcut issue that you are having? I have other reviews that depend on this one. I promise you to fix the shortcut bug <3

Apr 9 2019, 12:59 PM · Konsole