Differential D4511

Python bindings: Don't ignore the diagnostics from methodcode rules.
Needs ReviewPublic
Actions

Authored by shaheed on Feb 8 2017, 6:50 PM.

Details

Reviewers
skelly
Summary

Somehow with all the forking and merging, the diagnostics from using methodcode rules were being lost. This restores consistency with how the other rule databases are handled from a diagnostic point of view.

Test Plan

Visually inspect that the expected diagnostics are emitted. For example:

tmp/KWindowSystem/NETWM.sip: // Modified CONSTRUCTOR on line 988 'NETWinInfo' (by common_methodcode.py:code):

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
shaheed updated this revision to Diff 11084.Feb 8 2017, 6:50 PM
shaheed retitled this revision from to Don't ignore the diagnostics from methodcode rules..
shaheed updated this object.
shaheed edited the test plan for this revision. (Show Details)
shaheed retitled this revision from Don't ignore the diagnostics from methodcode rules. to Python bindings: Don't ignore the diagnostics from methodcode rules..Feb 8 2017, 6:56 PM
lbeltrame added a reviewer: skelly.Feb 9 2017, 6:10 AM
lbeltrame added a subscriber: skelly.

Revision Contents
Changeset List

PathPackages
Mfind-modules/sip_generator.py (16 lines)

Diff 11084

View Options

find-modules/sip_generator.py

Loading...